When performing batch modification, we call barcodedecode on any barcodes entered as a list, however, if a file is uploaded we do not. This should be done for consistency.
Created attachment 168796 [details] [review] Bug 37326: decode barcode file in inventory tool This patch ensures that barcodes uploaded as a file into batchMod are run through any transformations to match the behaviour of barcodes entered in a list To test: 1 - Edit BarcodeSeparators system preference to remove \s 2 - Install barcode transformer plugin: https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/tag/v1.2.0 3 - Configure the plguin: item: - match: "^[A-Z]* \| " search: "^[A-Z]* \| " replace: "" - match: " \| .*$" search: " \| .*$" replace: "" 4 - Go to Cataloging->Batch item modification 5 - Enter a list of barcodes into the 'Scan one by one' box like: ERR | 12345 | ERR FOO | 23456 | FOO BAR | 34567 | BAR 6 - Click 'Continue' 7 - Note the barcodes not found are: 12345 23456 34567 8 - Save the barcodes with extra text into a file 9 - Perform batch mod, supplying the barcodes via the file 10 - Note the barcodes not found are the original strings 11 - Apply patch, restart all 12 - Perform batch modification using file again 13 - Note the not found barcodes are the transformed version 14 - Sign off!
Created attachment 171393 [details] [review] Bug 37326: decode barcode file in inventory tool This patch ensures that barcodes uploaded as a file into batchMod are run through any transformations to match the behaviour of barcodes entered in a list To test: 1 - Edit BarcodeSeparators system preference to remove \s 2 - Install barcode transformer plugin: https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/tag/v1.2.0 3 - Configure the plguin: item: - match: "^[A-Z]* \| " search: "^[A-Z]* \| " replace: "" - match: " \| .*$" search: " \| .*$" replace: "" 4 - Go to Cataloging->Batch item modification 5 - Enter a list of barcodes into the 'Scan one by one' box like: ERR | 12345 | ERR FOO | 23456 | FOO BAR | 34567 | BAR 6 - Click 'Continue' 7 - Note the barcodes not found are: 12345 23456 34567 8 - Save the barcodes with extra text into a file 9 - Perform batch mod, supplying the barcodes via the file 10 - Note the barcodes not found are the original strings 11 - Apply patch, restart all 12 - Perform batch modification using file again 13 - Note the not found barcodes are the transformed version 14 - Sign off! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 174550 [details] [review] Bug 37326: decode barcode file in inventory tool This patch ensures that barcodes uploaded as a file into batchMod are run through any transformations to match the behaviour of barcodes entered in a list To test: 1 - Edit BarcodeSeparators system preference to remove \s 2 - Install barcode transformer plugin: https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/tag/v1.2.0 3 - Configure the plguin: item: - match: "^[A-Z]* \| " search: "^[A-Z]* \| " replace: "" - match: " \| .*$" search: " \| .*$" replace: "" 4 - Go to Cataloging->Batch item modification 5 - Enter a list of barcodes into the 'Scan one by one' box like: ERR | 12345 | ERR FOO | 23456 | FOO BAR | 34567 | BAR 6 - Click 'Continue' 7 - Note the barcodes not found are: 12345 23456 34567 8 - Save the barcodes with extra text into a file 9 - Perform batch mod, supplying the barcodes via the file 10 - Note the barcodes not found are the original strings 11 - Apply patch, restart all 12 - Perform batch modification using file again 13 - Note the not found barcodes are the transformed version 14 - Sign off! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11
Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason.