Bug 37340 - EDIFACT messages should be sortable by 'details'
Summary: EDIFACT messages should be sortable by 'details'
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Martin Renvoize
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on: 30070
Blocks:
  Show dependency treegraph
 
Reported: 2024-07-12 09:15 UTC by Martin Renvoize
Modified: 2024-08-28 20:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the EDIFACT messages table in acquisitions so that the details column is now sortable (Acquisitions > EDIFACT messages (when the EDIFACT system preference is enabled).
Version(s) released in:
24.11.00,24.05.04
Circulation function:


Attachments
Bug 37340: Restore sorting on 'Details' column in edifactmsgs (1.32 KB, patch)
2024-07-12 09:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 37340: Restore sorting on 'Details' column in edifactmsgs (1.37 KB, patch)
2024-07-12 20:00 UTC, David Nind
Details | Diff | Splinter Review
Bug 37340: Restore sorting on 'Details' column in edifactmsgs (1.85 KB, patch)
2024-07-24 09:50 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 37340: Restore sorting on 'Details' column in edifactmsgs (1.80 KB, patch)
2024-07-24 09:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 37340: Restore sorting on 'Details' column in edifactmsgs (1.85 KB, patch)
2024-07-24 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2024-07-12 09:15:00 UTC
Since bug 30070 that improves the performance of the edifactmesssages display table by converting the page to use ajax driven datatables, we have lost the ability to sort on the 'Details' column.

We should reinstate this option if at all possible.
Comment 1 Martin Renvoize 2024-07-12 09:24:59 UTC
Created attachment 168872 [details] [review]
Bug 37340: Restore sorting on 'Details' column in edifactmsgs

This patch restores the sorting options on the 'Details' field in the
edifact messages page.
Comment 2 David Nind 2024-07-12 20:00:41 UTC
Created attachment 168923 [details] [review]
Bug 37340: Restore sorting on 'Details' column in edifactmsgs

This patch restores the sorting options on the 'Details' field in the
edifact messages page.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-07-12 20:10:48 UTC
Note: I didn't test with any messages in the EDIFACT message table. I'm assuming that this is a standard DataTables feature, and should "just work". If this is not the case, please change the status of the bug back to needs sign-off.

Testing notes (using KTD):
1. Enable the EDIFACT system preference.
2. Go to the EDIFACT messages page (Acquisitions > EDIFACT messages).
3. Not that the details column does not have the sortable icon (like the Status, Vendor, and Filename columns).
4. Apply the patch.
5. Restart everything (restart_all).
6. Refresh the page.
7. Note that the details column now has the sortable icon.
Comment 4 Martin Renvoize 2024-07-24 09:50:25 UTC
Created attachment 169464 [details] [review]
Bug 37340: Restore sorting on 'Details' column in edifactmsgs

This patch restores the sorting options on the 'Details' field in the
edifact messages page.

We sort by basket_id followed by type behind the scenes, so the
resulting order for a Descending sort will group by basket id highest to
lowest with Quotes coming before Orders.

This is generally what the end user actually wants to see, even though
it may be somewhat unintuitive intially as it's not a clear alpha sort
for what's displayed in the column in the UI.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Mary Blomley <mary.blomley@uwl.ac.uk>
Comment 5 Martin Renvoize 2024-07-24 09:51:08 UTC
Created attachment 169465 [details] [review]
Bug 37340: Restore sorting on 'Details' column in edifactmsgs

This patch restores the sorting options on the 'Details' field in the
edifact messages page.

We sort by basket_id followed by type behind the scenes, so the
resulting order for a Descending sort will group by basket id highest to
lowest with Quotes coming before Orders.

This is generally what the end user actually wants to see, even though
it may be somewhat unintuitive intially as it's not a clear alpha sort
for what's displayed in the column in the UI.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Mary Blomley <mary.blomley@uwl.ac.uk>
Comment 6 Kyle M Hall 2024-07-24 10:56:43 UTC
Created attachment 169471 [details] [review]
Bug 37340: Restore sorting on 'Details' column in edifactmsgs

This patch restores the sorting options on the 'Details' field in the
edifact messages page.

We sort by basket_id followed by type behind the scenes, so the
resulting order for a Descending sort will group by basket id highest to
lowest with Quotes coming before Orders.

This is generally what the end user actually wants to see, even though
it may be somewhat unintuitive intially as it's not a clear alpha sort
for what's displayed in the column in the UI.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Mary Blomley <mary.blomley@uwl.ac.uk>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Martin Renvoize 2024-07-25 10:13:38 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 8 Lucas Gass 2024-08-28 20:33:50 UTC
Backported to 24.05.x for upcoming 24.05.04