Since bug 30070 that improves the performance of the edifactmesssages display table by converting the page to use ajax driven datatables, we have lost the ability to sort on the 'Details' column. We should reinstate this option if at all possible.
Created attachment 168872 [details] [review] Bug 37340: Restore sorting on 'Details' column in edifactmsgs This patch restores the sorting options on the 'Details' field in the edifact messages page.
Created attachment 168923 [details] [review] Bug 37340: Restore sorting on 'Details' column in edifactmsgs This patch restores the sorting options on the 'Details' field in the edifact messages page. Signed-off-by: David Nind <david@davidnind.com>
Note: I didn't test with any messages in the EDIFACT message table. I'm assuming that this is a standard DataTables feature, and should "just work". If this is not the case, please change the status of the bug back to needs sign-off. Testing notes (using KTD): 1. Enable the EDIFACT system preference. 2. Go to the EDIFACT messages page (Acquisitions > EDIFACT messages). 3. Not that the details column does not have the sortable icon (like the Status, Vendor, and Filename columns). 4. Apply the patch. 5. Restart everything (restart_all). 6. Refresh the page. 7. Note that the details column now has the sortable icon.
Created attachment 169464 [details] [review] Bug 37340: Restore sorting on 'Details' column in edifactmsgs This patch restores the sorting options on the 'Details' field in the edifact messages page. We sort by basket_id followed by type behind the scenes, so the resulting order for a Descending sort will group by basket id highest to lowest with Quotes coming before Orders. This is generally what the end user actually wants to see, even though it may be somewhat unintuitive intially as it's not a clear alpha sort for what's displayed in the column in the UI. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Mary Blomley <mary.blomley@uwl.ac.uk>
Created attachment 169465 [details] [review] Bug 37340: Restore sorting on 'Details' column in edifactmsgs This patch restores the sorting options on the 'Details' field in the edifact messages page. We sort by basket_id followed by type behind the scenes, so the resulting order for a Descending sort will group by basket id highest to lowest with Quotes coming before Orders. This is generally what the end user actually wants to see, even though it may be somewhat unintuitive intially as it's not a clear alpha sort for what's displayed in the column in the UI. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Mary Blomley <mary.blomley@uwl.ac.uk>
Created attachment 169471 [details] [review] Bug 37340: Restore sorting on 'Details' column in edifactmsgs This patch restores the sorting options on the 'Details' field in the edifact messages page. We sort by basket_id followed by type behind the scenes, so the resulting order for a Descending sort will group by basket id highest to lowest with Quotes coming before Orders. This is generally what the end user actually wants to see, even though it may be somewhat unintuitive intially as it's not a clear alpha sort for what's displayed in the column in the UI. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Mary Blomley <mary.blomley@uwl.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant
Backported to 24.05.x for upcoming 24.05.04