Bug 37343 - Cannot search for vendors when transferring an item in acquisitions
Summary: Cannot search for vendors when transferring an item in acquisitions
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Eric Garcia
QA Contact: Tomás Cohen Arazi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-12 13:15 UTC by Lucas Gass
Modified: 2024-09-10 13:11 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.02
Circulation function:


Attachments
Bug 37343: Fixed search for vendors when transferring an item in acquistions (1.43 KB, patch)
2024-07-16 17:11 UTC, Eric Garcia
Details | Diff | Splinter Review
Bug 37343: Fixed search for vendors when transferring an item in acquistions (1.49 KB, patch)
2024-07-18 15:45 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 37343: Fixed search for vendors when transferring an item in acquistions (1.49 KB, patch)
2024-07-18 15:45 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 37343: Fixed search for vendors when transferring an item in acquistions (1.54 KB, patch)
2024-07-18 16:59 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2024-07-12 13:15:49 UTC
To recreate:

1. Have several vendors in acquisitions
2. Add a basket and "+Add to basket"
3. I used a mrc file to add an order from a new file. 
4. Stage for import -> add staged files to basket 
5. Select the items and choose an item type
6. In the Orders table click 'Transfer' under the 'Modify' column.
7. Try searching for vendors, nothing happens.
Comment 1 Eric Garcia 2024-07-16 17:11:44 UTC
Created attachment 169052 [details] [review]
Bug 37343: Fixed search for vendors when transferring an item in acquistions

To test:
1. Have several vendors in acquistions
2. Add a basket and click "+Add to basket"
3. I used an mrc file to add an order from a new file
4. Stage for import -> add staged files to basket
5. Select the items and choose an item type
6. In the Orders table click 'Transfer' under the 'Modify' column
7. Try searching for vendors, nothing happens.
8. Apply patch restart_all
9. Click 'Transfer' again and try searching for vendors.
10. Notice vendors appear

NOTE:
Vendor search is a GET operation not POST. Use 'do_search' instead of 'cud-do_search'.
Comment 2 Kyle M Hall 2024-07-18 15:45:18 UTC
Created attachment 169147 [details] [review]
Bug 37343: Fixed search for vendors when transferring an item in acquistions

To test:
1. Have several vendors in acquistions
2. Add a basket and click "+Add to basket"
3. I used an mrc file to add an order from a new file
4. Stage for import -> add staged files to basket
5. Select the items and choose an item type
6. In the Orders table click 'Transfer' under the 'Modify' column
7. Try searching for vendors, nothing happens.
8. Apply patch restart_all
9. Click 'Transfer' again and try searching for vendors.
10. Notice vendors appear

NOTE:
Vendor search is a GET operation not POST. Use 'do_search' instead of 'cud-do_search'.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Tomás Cohen Arazi 2024-07-18 15:45:59 UTC
Created attachment 169148 [details] [review]
Bug 37343: Fixed search for vendors when transferring an item in acquistions

To test:
1. Have several vendors in acquistions
2. Add a basket and click "+Add to basket"
3. I used an mrc file to add an order from a new file
4. Stage for import -> add staged files to basket
5. Select the items and choose an item type
6. In the Orders table click 'Transfer' under the 'Modify' column
7. Try searching for vendors, nothing happens.
8. Apply patch restart_all
9. Click 'Transfer' again and try searching for vendors.
10. Notice vendors appear

NOTE:
Vendor search is a GET operation not POST. Use 'do_search' instead of 'cud-do_search'.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi 2024-07-18 16:58:17 UTC
We overlapped. Fixing.
Comment 5 Tomás Cohen Arazi 2024-07-18 16:59:29 UTC
Created attachment 169156 [details] [review]
Bug 37343: Fixed search for vendors when transferring an item in acquistions

To test:
1. Have several vendors in acquistions
2. Add a basket and click "+Add to basket"
3. I used an mrc file to add an order from a new file
4. Stage for import -> add staged files to basket
5. Select the items and choose an item type
6. In the Orders table click 'Transfer' under the 'Modify' column
7. Try searching for vendors, nothing happens.
8. Apply patch restart_all
9. Click 'Transfer' again and try searching for vendors.
10. Notice vendors appear

NOTE:
Vendor search is a GET operation not POST. Use 'do_search' instead of 'cud-do_search'.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Martin Renvoize 2024-07-22 06:38:07 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 7 Lucas Gass 2024-08-28 19:43:38 UTC
Backported to 24.05.x for upcoming 24.05.04
Comment 8 Fridolin Somers 2024-09-10 13:11:41 UTC
"cud-" not in 23.11.x