The new 'Protected Status' characteristic is something that could usefully be included as editable via Batch Patron Modification. Please consider adding.
+1
Created attachment 170932 [details] [review] Bug 37360: Add protected as a borrower mod option This patch adds protected status as a batch borrower modification option, if the user performing the modification is a superlibrarian. TO TEST: a) login as a superlibrarian b) attempt to batch modify these k.t.d user barcodes: 1) 23529000035676 2) 23529001000463 3) 23529000050113 c) notice that there is no protected option d) APPLY PATCH e) repeat step b f) notice that protected is now an option g) set all borrowers to protected (yes) 1) notice that the status has changed, in each individual user record h) set all borrowers to unprotected (no) 1) notice that the status has changed, in each individual user record i) set the proctedted status back to yes, but also set some other random options (e.g. city to Cork) 1) notice that the city and protected status are both updated j) use the disabled checkbox next to protected 1) notice that this always sets the protected status to zero k) SIGN OFF
Thanks in advance for the sign-off and QA :-) Jake.
Created attachment 170991 [details] [review] Bug 37360: Add protected as a borrower mod option This patch adds protected status as a batch borrower modification option, if the user performing the modification is a superlibrarian. TO TEST: a) login as a superlibrarian b) attempt to batch modify these k.t.d user barcodes: 1) 23529000035676 2) 23529001000463 3) 23529000050113 c) notice that there is no protected option d) APPLY PATCH e) repeat step b f) notice that protected is now an option g) set all borrowers to protected (yes) 1) notice that the status has changed, in each individual user record h) set all borrowers to unprotected (no) 1) notice that the status has changed, in each individual user record i) set the proctedted status back to yes, but also set some other random options (e.g. city to Cork) 1) notice that the city and protected status are both updated j) use the disabled checkbox next to protected 1) notice that this always sets the protected status to zero k) SIGN OFF Signed-off-by: Catrina <catrina@bywatersolutions.com>
Test plan works as described. Selecting the box to clear the value on "Protected" sets the users to "No" (not protected) - some clarifying helper text might be useful there.
Thanks for the sign-off, Catrina. I could add a tooltip, but it might also be worth considering properly documenting this? Jake.
Just curious, why push, push, unshift for the options for the dropdown? Could you just define them all at once or push the empty option first? I think the bigger issue is that the values will not be translatable, failing for this You also change the check for empty fields from a truth check to only assigning if not empty string, then checking if defined, is there a reason for that?
Thanks for the feedback. Because this hasn't been done before, I sort of adapted what's there. I guess the solution would be to put the Yes/No text within the template? I can put together a follow-up to address this. Jake.
Created attachment 172385 [details] [review] Bug 37360: (follow-up) added bool type to modborrowers This follow-up patch adds a bool type to modborrowers, so that the options can be translated within the template files.
All done – thanks for the FQA on this one. I think this is a much cleaner solution. Jake.
Looks like this one has been signed off already. Should it be marked as Signed off status?
Created attachment 172977 [details] [review] Bug 37360: Add protected as a borrower mod option This patch adds protected status as a batch borrower modification option, if the user performing the modification is a superlibrarian. TO TEST: a) login as a superlibrarian b) attempt to batch modify these k.t.d user barcodes: 1) 23529000035676 2) 23529001000463 3) 23529000050113 c) notice that there is no protected option d) APPLY PATCH e) repeat step b f) notice that protected is now an option g) set all borrowers to protected (yes) 1) notice that the status has changed, in each individual user record h) set all borrowers to unprotected (no) 1) notice that the status has changed, in each individual user record i) set the proctedted status back to yes, but also set some other random options (e.g. city to Cork) 1) notice that the city and protected status are both updated j) use the disabled checkbox next to protected 1) notice that this always sets the protected status to zero k) SIGN OFF Signed-off-by: Catrina <catrina@bywatersolutions.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 172978 [details] [review] Bug 37360: (follow-up) added bool type to modborrowers This follow-up patch adds a bool type to modborrowers, so that the options can be translated within the template files. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 173273 [details] [review] Bug 37360: Add protected as a borrower mod option This patch adds protected status as a batch borrower modification option, if the user performing the modification is a superlibrarian. TO TEST: a) login as a superlibrarian b) attempt to batch modify these k.t.d user barcodes: 1) 23529000035676 2) 23529001000463 3) 23529000050113 c) notice that there is no protected option d) APPLY PATCH e) repeat step b f) notice that protected is now an option g) set all borrowers to protected (yes) 1) notice that the status has changed, in each individual user record h) set all borrowers to unprotected (no) 1) notice that the status has changed, in each individual user record i) set the proctedted status back to yes, but also set some other random options (e.g. city to Cork) 1) notice that the city and protected status are both updated j) use the disabled checkbox next to protected 1) notice that this always sets the protected status to zero k) SIGN OFF
Created attachment 173274 [details] [review] Bug 37360: (follow-up) added bool type to modborrowers This follow-up patch adds a bool type to modborrowers, so that the options can be translated within the template files.
Ah whoops, removed the SO lines... one tick
Created attachment 173275 [details] [review] Bug 37360: Add protected as a borrower mod option This patch adds protected status as a batch borrower modification option, if the user performing the modification is a superlibrarian. TO TEST: a) login as a superlibrarian b) attempt to batch modify these k.t.d user barcodes: 1) 23529000035676 2) 23529001000463 3) 23529000050113 c) notice that there is no protected option d) APPLY PATCH e) repeat step b f) notice that protected is now an option g) set all borrowers to protected (yes) 1) notice that the status has changed, in each individual user record h) set all borrowers to unprotected (no) 1) notice that the status has changed, in each individual user record i) set the proctedted status back to yes, but also set some other random options (e.g. city to Cork) 1) notice that the city and protected status are both updated j) use the disabled checkbox next to protected 1) notice that this always sets the protected status to zero k) SIGN OFF Signed-off-by: Catrina <catrina@bywatersolutions.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 173276 [details] [review] Bug 37360: (follow-up) added bool type to modborrowers This follow-up patch adds a bool type to modborrowers, so that the options can be translated within the template files. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Those patches are now rebased on main :-) Jake.