Bug 37366 - Patron category "Password change in OPAC" setting only follows system preference
Summary: Patron category "Password change in OPAC" setting only follows system preference
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 24.05
Hardware: All All
: P5 - low normal
Assignee: Kyle M Hall (khall)
QA Contact: Matt Blenkinsop
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-15 17:57 UTC by Heather Rommens
Modified: 2024-11-18 18:39 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 37366: Patron category "Password change in OPAC" setting only follows system preference (1.47 KB, patch)
2024-07-18 18:06 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 37366: Patron category "Password change in OPAC" setting only follows system preference (1.52 KB, patch)
2024-07-18 21:08 UTC, Roman Dolny 		Details | Diff | Splinter Review
Bug 37366: Patron category "Password change in OPAC" setting only follows system preference (1.67 KB, patch)
2024-07-22 13:43 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 37366: Patron category "Password change in OPAC" setting only follows system preference (1.75 KB, patch)
2024-07-26 11:05 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Heather Rommens 2024-07-15 17:57:08 UTC 
In Administration > Patron categories, when setting the Password change in OPAC field, Koha will not save "Allowed" or "Not allowed" options, and will only keep "Follow the system preference OPACPasswordChange..." value.
Comment 1 Kyle M Hall (khall) 2024-07-18 18:06:43 UTC 
Created attachment 169163 [details] [review]
Bug 37366: Patron category "Password change in OPAC" setting only follows system preference

In Administration > Patron categories, when setting the Password change in OPAC field, Koha will not save "Allowed" or "Not allowed" options, and will only keep "Follow the system preference OPACPasswordChange..." value.

Test Plan:
1) Change the Password change in OPAC field
2) Note the change doesn't take affect
3) Apply this patch
4) Change the field again
5) This time is stays!
Comment 2 Kyle M Hall (khall) 2024-07-18 18:07:14 UTC 
Looks like this was accidentally change the the CSRF script.
Comment 3 Roman Dolny 2024-07-18 21:08:58 UTC 
Created attachment 169169 [details] [review]
Bug 37366: Patron category "Password change in OPAC" setting only follows system preference

In Administration > Patron categories, when setting the Password change in OPAC field, Koha will not save "Allowed" or "Not allowed" options, and will only keep "Follow the system preference OPACPasswordChange..." value.

Test Plan:
1) Change the Password change in OPAC field
2) Note the change doesn't take affect
3) Apply this patch
4) Change the field again
5) This time is stays!

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 4 Kyle M Hall (khall) 2024-07-22 13:43:20 UTC 
Created attachment 169284 [details] [review]
Bug 37366: Patron category "Password change in OPAC" setting only follows system preference

In Administration > Patron categories, when setting the Password change in OPAC field, Koha will not save "Allowed" or "Not allowed" options, and will only keep "Follow the system preference OPACPasswordChange..." value.

Test Plan:
1) Change the Password change in OPAC field
2) Note the change doesn't take affect
3) Apply this patch
4) Change the field again
5) This time is stays!

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 5 Matt Blenkinsop 2024-07-26 11:05:00 UTC 
Created attachment 169690 [details] [review]
Bug 37366: Patron category "Password change in OPAC" setting only follows system preference

In Administration > Patron categories, when setting the Password change in OPAC field, Koha will not save "Allowed" or "Not allowed" options, and will only keep "Follow the system preference OPACPasswordChange..." value.

Test Plan:
1) Change the Password change in OPAC field
2) Note the change doesn't take affect
3) Apply this patch
4) Change the field again
5) This time is stays!

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 6 Martin Renvoize (ashimema) 2024-07-26 12:55:58 UTC 
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 7 Lucas Gass (lukeg) 2024-08-29 15:03:55 UTC 
Doesn't apply to 24.05.x branch