I noticed that when you stage MARC records and do a match check ("Look for existing records in catalog?"), the progress quantity in the Details of the job is wrong. To recreate: 1. Go to Cataloging > Stage records for import 2. Choose a file with bibliographic records and click Upload file 3. In "Look for existing records in catalog?" choose a record matching rule (e.g. ISBN) 4. Click Stage for import 5. Click View detail of the enqueued job --> Progress show 2/1 I've also seen 4/2 and 12500/1000 (it's not always double) The number seems ok if you don't check for existing records. This has been the case at least since 23.05.
Created attachment 169509 [details] [review] Bug 37403 : Wrong progress quantity in job details In fact the system adds a previous value to the progress. As if the system keeps a previous value and adds the correct count of records in addition. This patch removes the previously stored value. To test: 1. Go to Cataloging > Stage records for import 2. Choose a file with bibliographic records and click Upload file 3. In "Look for existing records in catalog?" choose a record matching rule (e.g. ISBN) 4. Click Stage for import 5. Click View detail of the enqueued job --> Progress show 2/1 6. Apply the patch 7. Repeat steps 1 to 4 8. Click View detail of the enqueued job --> Progress show 1/1
Created attachment 169519 [details] [review] Bug 37403 : Wrong progress quantity in job details In fact the system adds a previous value to the progress. As if the system keeps a previous value and adds the correct count of records in addition. This patch removes the previously stored value. To test: 1. Go to Cataloging > Stage records for import 2. Choose a file with bibliographic records and click Upload file 3. In "Look for existing records in catalog?" choose a record matching rule (e.g. ISBN) 4. Click Stage for import 5. Click View detail of the enqueued job --> Progress show 2/1 6. Apply the patch 7. Repeat steps 1 to 4 8. Click View detail of the enqueued job --> Progress show 1/1 Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> qa script: Commit title does not start with 'Bug XXXXX: ' - d1bebb34d7
Created attachment 172939 [details] [review] Bug 37403: Wrong progress quantity in job details In fact the system adds a previous value to the progress. As if the system keeps a previous value and adds the correct count of records in addition. This patch removes the previously stored value. To test: 1. Go to Cataloging > Stage records for import 2. Choose a file with bibliographic records and click Upload file 3. In "Look for existing records in catalog?" choose a record matching rule (e.g. ISBN) 4. Click Stage for import 5. Click View detail of the enqueued job --> Progress show 2/1 6. Apply the patch 7. Repeat steps 1 to 4 8. Click View detail of the enqueued job --> Progress show 1/1 Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> qa script: Commit title does not start with 'Bug XXXXX: ' - d1bebb34d7 Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Fixed patch subject line
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11