If I try to export to CSV from aqplan.pl (Acquisitions > Budgets > Funds > Planning), I get a 500 error. This is happening in 23.05.10, 23.05.11, and 24.05, and whether I'm planning the budget by months, libraries, or item types.
Created attachment 169847 [details] [review] Bug 37411: Fixed 500 error when exporting budget planning To test: 1. Acquistions -> Budgets -> Funds -> Planning, select any option 2. In the toolbar see Export, and click Submit and see a 500 error 3. Apply patch, restart_all 4. Repeat steps 1-2 5. Notice the 500 error is gone and the CSV is exported properly Notes: Is there a reason we call exit(1) after exporting the csv?
After applying a patch problem with 500 error is gone. However, the CSV file is not exported correctly - it contains not only budget data but also HTML page generated by output_html_with_http_headers: Status: 200 OK Set-Cookie: CGISESSID=b23f65baf79e7d7752b6cea526a6fd69; path=/; HttpOnly; SameSite=Lax Date: Mon, 29 Jul 2024 16:29:20 GMT Cache-control: no-cache Content-script-type: text/javascript Content-style-type: text/css Pragma: no-cache X-frame-options: SAMEORIGIN Content-Type: text/html; charset=UTF-8 <!DOCTYPE html> <!-- TEMPLATE FILE: aqplan.tt --> <html lang="en"> <head> ...
Created attachment 169910 [details] [review] Bug 37411: Fixed exporting to csv file To test: 1. Acquistions -> Budgets -> Funds -> Planning, select any option 2. In the toolbar see Export, and click Submit and see a 500 error 3. Apply patch, restart_all 4. Repeat steps 1-2 5. Notice the 500 error is gone and the CSV is exported properly
Created attachment 169912 [details] [review] Bug 37411: Fixed 500 error when exporting budget planning To test: 1. Acquistions -> Budgets -> Funds -> Planning, select any option 2. In the toolbar see Export, and click Submit and see a 500 error 3. Apply patch, restart_all 4. Repeat steps 1-2 5. Notice the 500 error is gone and the CSV is exported properly Notes: Is there a reason we call exit(1) after exporting the csv? Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 169913 [details] [review] Bug 37411: Fixed exporting to csv file To test: 1. Acquistions -> Budgets -> Funds -> Planning, select any option 2. In the toolbar see Export, and click Submit and see a 500 error 3. Apply patch, restart_all 4. Repeat steps 1-2 5. Notice the 500 error is gone and the CSV is exported properly Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 169936 [details] [review] Bug 37411: Fixed 500 error when exporting budget planning To test: 1. Acquistions -> Budgets -> Funds -> Planning, select any option 2. In the toolbar see Export, and click Submit and see a 500 error 3. Apply patch, restart_all 4. Repeat steps 1-2 5. Notice the 500 error is gone and the CSV is exported properly Notes: Is there a reason we call exit(1) after exporting the csv? Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 169937 [details] [review] Bug 37411: Fixed exporting to csv file To test: 1. Acquistions -> Budgets -> Funds -> Planning, select any option 2. In the toolbar see Export, and click Submit and see a 500 error 3. Apply patch, restart_all 4. Repeat steps 1-2 5. Notice the 500 error is gone and the CSV is exported properly Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.04
Pushed to 23.11.x for 23.11.09
Not backporting to 23.05.x unless requested