We would like to request an enhancement for cover images to be visible on the check out/issues screen a the time of issuing books. We would like this option to be enabled for specific borrower categories, eg we would enable for student and staff categories, but not for general borrower categories such as Library trollies.
Created attachment 169807 [details] [review] Bug 37463: Adding system preference.
Created attachment 169808 [details] [review] Bug 37463: Adding system preference.
Created attachment 169809 [details] [review] Bug 37463: Adding system preference.
Created attachment 169852 [details] [review] Bug 37463: Adding system preference.
Created attachment 170492 [details] [review] Bug 37463: Adding system preference. This patch allows cover images to display in the patron checkout module for selected patron categories but only ones from Amazon for now. Test plan: Step 1 - apply this patch Step 2 - Make sure AmazonCoverImages syspref is set to "show" step 3 - Search for the CoverImagesCategories syspref and enable it for a specific patron category (choose the category that your patron account is) step 4 - checkout an item to your patron account step 5 - in the patron checkouts page, click the "show checkouts" button, you should see the items cover image there, as long as there is one available from Amazon
Bug 37463: Adding system preference. This patch allows cover images to display in the patron checkout module for selected patron categories but only ones from Amazon for now. Test plan: Step 1 - apply this patch Step 2 - Make sure AmazonCoverImages syspref is set to "show" step 3 - Search for the CoverImagesCategories syspref and enable it for a specific patron category (choose the category that your patron account is) step 4 - checkout an item to your patron account step 5 - in the patron checkouts page, click the "show checkouts" button, you should see the items cover image there, as long as there is one available from Amazon Sponsored by: Pymble Ladies College
Applying: Bug 37463: Adding system preference. .git/rebase-apply/patch:92: trailing whitespace. + '.01.LZZZZZZZ.jpg" title="Amazon cover image"><img src="https://images-na.ssl-images-amazon.com/images/P/' .git/rebase-apply/patch:93: trailing whitespace. + oObj.isbn .git/rebase-apply/patch:116: trailing whitespace. error: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/bug_37463-add_SCOCoverImagesCategories_syspref.pl). error: could not build fake ancestor Patch failed at 0001 Bug 37463: Adding system preference.
Created attachment 170623 [details] [review] Bug 37463: Show Amazon cover images in checkouts table for selected patron categories This patch allows cover images to display in the patron checkout module for selected patron categories but only ones from Amazon for now. Test plan: Step 1 - apply this patch Step 2 - Make sure AmazonCoverImages syspref is set to "show" step 3 - Search for the CoverImagesCategories syspref and enable it for a specific patron category (choose the category that your patron account is) step 4 - checkout an item to your patron account step 5 - in the patron checkouts page, click the "show checkouts" button, you should see the items cover image there, as long as there is one available from Amazon
Created attachment 170686 [details] [review] Bug 37463: Show Amazon cover images in checkouts table for selected patron categories This patch allows cover images to display in the patron checkout module for selected patron categories but only ones from Amazon for now. Test plan: Step 1 - apply this patch Step 2 - Make sure AmazonCoverImages syspref is set to "show" step 3 - Search for the CoverImagesCategories syspref and enable it for a specific patron category (choose the category that your patron account is) step 4 - checkout an item to your patron account step 5 - in the patron checkouts page, click the "show checkouts" button, you should see the items cover image there, as long as there is one available from Amazon Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
I think you'll have to do something to deal with the 1px by 1px images that Amazon sometimes returns. In k-t-d I checked out itemnumber 308. You get the 1px by 1px image, which looks like no image at all, and then the text 'Image from Amazon.com'. You can see how its dealt with currently in js/pages/results.js.
Created attachment 177462 [details] [review] Bug 37463: Show Amazon cover images in checkouts table for selected patron categories This patch allows cover images to display in the patron checkout module for selected patron categories but only ones from Amazon for now. Test plan: Step 1 - apply this patch Step 2 - Make sure AmazonCoverImages syspref is set to "show" step 3 - Search for the CoverImagesCategories syspref and enable it for a specific patron category (choose the category that your patron account is) step 4 - checkout an item to your patron account step 5 - in the patron checkouts page, click the "show checkouts" button, you should see the items cover image there, as long as there is one available from Amazon Sponsored by: Pymble Ladies College
Created attachment 177606 [details] [review] Bug 37463: Show Amazon cover images in checkouts table for selected patron categories This patch allows cover images to display in the patron checkout module for selected patron categories but only ones from Amazon for now. Test plan: Step 1 - apply this patch Step 2 - Make sure AmazonCoverImages syspref is set to "show" step 3 - Search for the CoverImagesCategories syspref and enable it for a specific patron category (choose the category that your patron account is) step 4 - checkout an item to your patron account step 5 - in the patron checkouts page, click the "show checkouts" button, you should see the items cover image there, as long as there is one available from Amazon Sponsored by: Pymble Ladies College
(In reply to Lucas Gass (lukeg) from comment #10) > I think you'll have to do something to deal with the 1px by 1px images that > Amazon sometimes returns. In k-t-d I checked out itemnumber 308. You get the > 1px by 1px image, which looks like no image at all, and then the text 'Image > from Amazon.com'. > > You can see how its dealt with currently in js/pages/results.js. Thanks for your advice! I have now implemented dealing with 1px by 1px images from Amazon.com