Bug 37485 - Hold rules not respected for item groups if other items on bib are holdable
Summary: Hold rules not respected for item groups if other items on bib are holdable
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: 24.05
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-25 21:15 UTC by Sara Brown
Modified: 2024-08-19 20:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sara Brown 2024-07-25 21:15:21 UTC
Circulation rules that limit holds aren't working properly when items with 0 allowed holds are added to item groups if there are holdable items on the bib, even if all items in a group have 0 holds allowed. To replicate:

1. Set circ rules to 0 holds allowed for test patron category/item type (ex: reference)
2. Create item with item type reference
3. Try to place hold, and note message saying holds aren't allowed (in this scenario, it can be placed by override) - works as expected. At this step, I'm also unable to place a hold via the OPAC.
4. Create an item group (REF), and add your reference item to it
5. Add another item to the bib that *is* holdable
6. Select your patron to place a hold. Note that there is no error message (which makes sense, since once item is holdable).
7. Select the 'Hold next available item from an item group' radio button, and then select your REF group. Note that there is no indication that the only item in this group is not holdable.
8. Click 'Place hold'. The hold places successfully, and there is no warning or popup that this hold isn't allowed.

I can also successfully place a hold on the REF item group from the OPAC. 

The behavior appears to be the same in 23.05.10, 23.11, and 24.05.
Comment 1 Chanel Wheeler 2024-08-15 20:21:19 UTC
+1 We've gotten bitten by this.