Bug 37496 - Link to item details from holdings table links to all items
Summary: Link to item details from holdings table links to all items
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Emily Lamancusa
QA Contact: Testopia
URL:
Keywords: regression
Depends on: 33568
Blocks:
  Show dependency treegraph
 
Reported: 2024-07-26 15:31 UTC by Emily Lamancusa
Modified: 2024-09-06 16:23 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.04
Circulation function:


Attachments
Bug 37496: Restore parameter to limit to details of one item (1.74 KB, patch)
2024-07-26 15:40 UTC, Emily Lamancusa
Details | Diff | Splinter Review
Bug 37496: Restore parameter to limit to details of one item (1.79 KB, patch)
2024-07-26 16:44 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 37496: Restore parameter to limit to details of one item (1.85 KB, patch)
2024-08-01 18:43 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa 2024-07-26 15:31:44 UTC
In the past, clicking on a barcode from the holdings table would link to the item details page for just that item. The url in the current code is missing the parameter to limit to just that item.
Comment 1 Emily Lamancusa 2024-07-26 15:40:48 UTC
Created attachment 169752 [details] [review]
Bug 37496: Restore parameter to limit to details of one item

To test:
1. Find a bib record with more than one item
2. Click on the barcode of an item to show the item details page
--> The item details page shows the details of all items, though it does
    jump to the correct item
3. Apply patch
4. Reload the bib record, and click the barcode again
--> The item details page shows only the chosen item, with a link above
    to show all items
Comment 2 Roman Dolny 2024-07-26 16:44:44 UTC
Created attachment 169762 [details] [review]
Bug 37496: Restore parameter to limit to details of one item

To test:
1. Find a bib record with more than one item
2. Click on the barcode of an item to show the item details page
--> The item details page shows the details of all items, though it does
    jump to the correct item
3. Apply patch
4. Reload the bib record, and click the barcode again
--> The item details page shows only the chosen item, with a link above
    to show all items

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Nick Clemens (kidclamp) 2024-08-01 18:43:16 UTC
Created attachment 169962 [details] [review]
Bug 37496: Restore parameter to limit to details of one item

To test:
1. Find a bib record with more than one item
2. Click on the barcode of an item to show the item details page
--> The item details page shows the details of all items, though it does
    jump to the correct item
3. Apply patch
4. Reload the bib record, and click the barcode again
--> The item details page shows only the chosen item, with a link above
    to show all items

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-08-02 17:01:43 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass 2024-09-06 16:23:03 UTC
Backported to 24.05.x for upcoming 24.05.04