If an item is scanned with a statistical patron, the the page is meant to display an alert if the item has any current checkouts, holds, recalls, return claims, or lost/withdrawn status (as well as automatically ending checkouts and clearing lost statuses). However, the page is not currently displaying those alerts unless the item has a current checkout, even though the other statuses are unrelated to whether the item is currently checked out or not.
It looks like bug 27992 added this information for all stats checkouts, then 35950 changed it to only return the book if checked out. If we are to check in the book each time to show the messages I think we need to add a way to skip the stats for return for each statistical checkout.
> If we are to check in the book each time to show the messages I think we > need to add a way to skip the stats for return for each statistical checkout. If the item is not checked out, right? If it is checked out we want to record the return and the localuse.
Created attachment 170888 [details] [review] Bug 37505: Remove onloan check when checking out to stats patron To test: 1. Create a Statistical Patron 2. Set BlockReturnOfLostItems to Block. 3.. Mark an item as lost 4. Check it out to the Statistical Patron. You should see the message "Item was lost, cannot be returned." 5. Set BlockReturnOfWithdrawnItems to Block. 6. Mark an item as withdrawn 7. Check it out to the Statistical Patron. You should see the message "Item was withdrawn, cannot be returned." 8. Turn off BlockReturnOfWithdrawnItems, check out the same item to the Statistical Patron. You should see a message "Item was withdrawn." 9. Place an item on hold. 10. Check it out to the Statistical Patron 11. See the message "Item on hold, please checkin." 12. Make sure ClaimReturnedLostValue is set to a lost value 13. Claim a return, making sure it is not still checked out to the patron 14. Checkit it out to the Statistical Patron. 15. See the message "Item claimed returned, please checkin." 16. Have an item on a regular patron account that has been recalled. 17. Checkit it out to the Statistical Patron. 18. See the message "Item can fill a recall, please checkin."
Created attachment 170911 [details] [review] Bug 37505: Remove onloan check when checking out to stats patron To test: 1. Create a Statistical Patron 2. Set BlockReturnOfLostItems to Block. 3.. Mark an item as lost 4. Check it out to the Statistical Patron. You should see the message "Item was lost, cannot be returned." 5. Set BlockReturnOfWithdrawnItems to Block. 6. Mark an item as withdrawn 7. Check it out to the Statistical Patron. You should see the message "Item was withdrawn, cannot be returned." 8. Turn off BlockReturnOfWithdrawnItems, check out the same item to the Statistical Patron. You should see a message "Item was withdrawn." 9. Place an item on hold. 10. Check it out to the Statistical Patron 11. See the message "Item on hold, please checkin." 12. Make sure ClaimReturnedLostValue is set to a lost value 13. Claim a return, making sure it is not still checked out to the patron 14. Checkit it out to the Statistical Patron. 15. See the message "Item claimed returned, please checkin." 16. Have an item on a regular patron account that has been recalled. 17. Checkit it out to the Statistical Patron. 18. See the message "Item can fill a recall, please checkin." Signed-off-by: Kelly <kelly@bywatersolutions.com>