When POSTing { "amount": 1.17, "description": "some description", "internal_note": "internal_noteo", "type": "MANUAL", "user_id": 17 } to http://localhost:8081/api/v1/patrons/5/account/debits I would expect patron 5 to be debited by user_id 17. At least that is what the definition for debit says. But instead the belated patron is also shown as librarian in http://localhost:8081/cgi-bin/koha/members/accountline-details.pl?accountlines_id=<ACCOUNTLINE FROM RESPONSE> When POSTing without user_id I would expect that the user_id is gained from the api user, but also the belated patron is shown as librarian.
Created attachment 169887 [details] [review] Bug 37535: Adding a debit via API will show the belated patron as the librarian that caused the debit This patch fixes the addPatronDebit route so that the librarian that caused the debit is taken from either the requests payload user_id or if not set from the api user. Test plan: a) enable system preference RESTBasicAuth b) use a REST client to send a POST request with the following JSON body to http://localhost:8081/api/v1/patrons/5/account/debits { "amount": 1.23, "description": "some description", "internal_note": "internal_note", "type": "MANUAL" } Authentication username and password is "koha" c) verify that "user_id" is the same as patron_id in response. d) send a different request including user_id to the same endpoint { "amount": 1.23, "description": "some description", "internal_note": "internal_note", "type": "MANUAL", "user_id": 19 } e) verify that "user_id" is the same as patron_id in response. f) apply patch and repeat step b) and d) e) verify that user_id in b) is now 51 (which is the borrowernumber of koha user) f) verify that user_id in d) is now 19 as defined in request g) recheck on http://localhost:8081/cgi-bin/koha/members/accountline-details.pl?accountlines_id=<account_line_id> (from response) that column Librarian now says the user from user_id h) sign off :)
Created attachment 169905 [details] [review] Bug 37535: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 169906 [details] [review] Bug 37535: Adding a debit via API will show the belated patron as the librarian that caused the debit This patch fixes the addPatronDebit route so that the librarian that caused the debit is taken from either the requests payload user_id or if not set from the api user. Test plan: a) enable system preference RESTBasicAuth b) use a REST client to send a POST request with the following JSON body to http://localhost:8081/api/v1/patrons/5/account/debits { "amount": 1.23, "description": "some description", "internal_note": "internal_note", "type": "MANUAL" } Authentication username and password is "koha" c) verify that "user_id" is the same as patron_id in response. d) send a different request including user_id to the same endpoint { "amount": 1.23, "description": "some description", "internal_note": "internal_note", "type": "MANUAL", "user_id": 19 } e) verify that "user_id" is the same as patron_id in response. f) apply patch and repeat step b) and d) e) verify that user_id in b) is now 51 (which is the borrowernumber of koha user) f) verify that user_id in d) is now 19 as defined in request g) recheck on http://localhost:8081/cgi-bin/koha/members/accountline-details.pl?accountlines_id=<account_line_id> (from response) that column Librarian now says the user from user_id h) sign off :) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I wrote tests once I so you filed this bug. I confirm your patch fixes the issue. A revisited test plan (using the tests) would be: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/patrons_accounts.t => FAIL: Tests fail. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass :-D
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11