Bug 37575 - Typo 'AutoCreateAuthorites' in about.pl
Summary: Typo 'AutoCreateAuthorites' in about.pl
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 30025
Blocks:
  Show dependency tree / graph
 
Reported: 2024-08-06 12:03 UTC by Fridolin Somers
Modified: 2024-11-15 15:36 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.04,23.11.11
Circulation function:

Attachments
Bug 37575: Typo 'AutoCreateAuthorites' in about.pl (3.65 KB, patch)
2024-08-06 12:15 UTC, Fridolin Somers 		Details | Diff | Splinter Review
Bug 37575: Typo 'AutoCreateAuthorites' in about.pl (3.71 KB, patch)
2024-08-13 03:44 UTC, Phil Ringnalda 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2024-08-06 12:03:09 UTC 
Typo in system preference name 'AutoCreateAuthorites' ->  'AutoCreateAuthorit[i]es'
Comment 1 Fridolin Somers 2024-08-06 12:15:54 UTC 
Created attachment 170092 [details] [review]
Bug 37575: Typo 'AutoCreateAuthorites' in about.pl

Typo in system preference name 'AutoCreateAuthorites' ->  'AutoCreateAuthorit[i]es'
Comment 2 Barbara Johnson 2024-08-06 17:25:39 UTC 
I applied the patch but got an error message. However, it did correct the typo so I tried signing off. But I'm getting an error message for that as well:

Saved working directory and index state WIP on (no branch): 8ff9e665e4 Bug 37303: Update yarn.lock after adding new dependency to packages.json
/bin/sh: 1: Johnson: not found
fatal: It looks like 'git am' is in progress. Cannot rebase.

[31mHEAD detached at [morigin/main
You are in the middle of an am session.
  (fix conflicts and then run "git am --continue")
  (use "git am --skip" to skip this patch)
  (use "git am --abort" to restore the original branch)

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	[31mmodified:   koha-tmpl/intranet-tmpl/prog/en/modules/about.tt[m

no changes added to commit (use "git add" and/or "git commit -a")
Dropped refs/stash@{0} (f73facb8f7d8e6d26a1487bb4a2b212e2b05da08) 

I have no idea what any of this means but I couldn't proceed with the sign off.
Comment 3 Phil Ringnalda 2024-08-13 03:44:03 UTC 
Created attachment 170252 [details] [review]
Bug 37575: Typo 'AutoCreateAuthorites' in about.pl

Typo in system preference name 'AutoCreateAuthorites' ->  'AutoCreateAuthorit[i]es'

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 4 Katrin Fischer 2024-08-13 07:45:37 UTC 
Speeding this up RM style :)
Comment 5 Katrin Fischer 2024-08-16 14:25:18 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-09-11 16:29:21 UTC 
Backported to 24.05.x for 24.05.04
Comment 7 Fridolin Somers 2024-11-15 15:36:39 UTC 
Pushed to 23.11.x for 23.11.11