Bug 37580 - Unique holiday descriptions are not editable
Summary: Unique holiday descriptions are not editable
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: CJ Lynce
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 36192
Blocks:
  Show dependency treegraph
 
Reported: 2024-08-06 14:06 UTC by Donna
Modified: 2024-08-16 15:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37580: Unique Holidays Description are not editable (2.34 KB, patch)
2024-08-06 14:32 UTC, CJ Lynce
Details | Diff | Splinter Review
Bug 37580: Unique Holidays Description are not editable (2.38 KB, patch)
2024-08-06 19:30 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 37580: Unique Holidays Description are not editable (2.48 KB, patch)
2024-08-16 07:30 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Donna 2024-08-06 14:06:58 UTC
In 24.05 (confirmed works in 23.11 and 23.05) once you have created a unique holiday, you cannot edit the description.

To replicate:
1. Find or create a new unique holiday with a description.
2. Click on the date to edit
3. Change the description and click Save
4. The description both in the Unique Holidays box and the holiday itself does not change.
Comment 1 CJ Lynce 2024-08-06 14:32:39 UTC
Created attachment 170101 [details] [review]
Bug 37580: Unique Holidays Description are not editable

Holiday names and descriptions are not editable after creation in
    tools/holiday.pl.
This patch corrects this regression.

To test:

1) Login to staff client
2) Open Tools -> Calendar
3) Click on a date and create a holiday with name and description.
4) Save holiday.
5) Click on newly created holiday on calendar and edit the name and
   description.
6) Re-Save Holiday.
7) Click again on holiday, and see that name and description changes
   did not save.
8) Apply patch
9) Repeat steps 5-7
10) Verify that changes now save.

Sponsored-by: Westlake Porter Public Library
Comment 2 ByWater Sandboxes 2024-08-06 19:30:30 UTC
Created attachment 170112 [details] [review]
Bug 37580: Unique Holidays Description are not editable

Holiday names and descriptions are not editable after creation in
    tools/holiday.pl.
This patch corrects this regression.

To test:

1) Login to staff client
2) Open Tools -> Calendar
3) Click on a date and create a holiday with name and description.
4) Save holiday.
5) Click on newly created holiday on calendar and edit the name and
   description.
6) Re-Save Holiday.
7) Click again on holiday, and see that name and description changes
   did not save.
8) Apply patch
9) Repeat steps 5-7
10) Verify that changes now save.

Sponsored-by: Westlake Porter Public Library
Signed-off-by: Martha <msulllivan@rcls.org>
Comment 3 Marcel de Rooy 2024-08-16 07:30:42 UTC
Created attachment 170433 [details] [review]
Bug 37580: Unique Holidays Description are not editable

Holiday names and descriptions are not editable after creation in
    tools/holiday.pl.
This patch corrects this regression.

To test:

1) Login to staff client
2) Open Tools -> Calendar
3) Click on a date and create a holiday with name and description.
4) Save holiday.
5) Click on newly created holiday on calendar and edit the name and
   description.
6) Re-Save Holiday.
7) Click again on holiday, and see that name and description changes
   did not save.
8) Apply patch
9) Repeat steps 5-7
10) Verify that changes now save.

Sponsored-by: Westlake Porter Public Library
Signed-off-by: Martha <msulllivan@rcls.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2024-08-16 07:30:59 UTC
CSRF related
Comment 5 Katrin Fischer 2024-08-16 15:37:35 UTC
Pushed for 24.11!

Well done everyone, thank you!