In 24.05 (confirmed works in 23.11 and 23.05) once you have created a unique holiday, you cannot edit the description. To replicate: 1. Find or create a new unique holiday with a description. 2. Click on the date to edit 3. Change the description and click Save 4. The description both in the Unique Holidays box and the holiday itself does not change.
Created attachment 170101 [details] [review] Bug 37580: Unique Holidays Description are not editable Holiday names and descriptions are not editable after creation in tools/holiday.pl. This patch corrects this regression. To test: 1) Login to staff client 2) Open Tools -> Calendar 3) Click on a date and create a holiday with name and description. 4) Save holiday. 5) Click on newly created holiday on calendar and edit the name and description. 6) Re-Save Holiday. 7) Click again on holiday, and see that name and description changes did not save. 8) Apply patch 9) Repeat steps 5-7 10) Verify that changes now save. Sponsored-by: Westlake Porter Public Library
Created attachment 170112 [details] [review] Bug 37580: Unique Holidays Description are not editable Holiday names and descriptions are not editable after creation in tools/holiday.pl. This patch corrects this regression. To test: 1) Login to staff client 2) Open Tools -> Calendar 3) Click on a date and create a holiday with name and description. 4) Save holiday. 5) Click on newly created holiday on calendar and edit the name and description. 6) Re-Save Holiday. 7) Click again on holiday, and see that name and description changes did not save. 8) Apply patch 9) Repeat steps 5-7 10) Verify that changes now save. Sponsored-by: Westlake Porter Public Library Signed-off-by: Martha <msulllivan@rcls.org>
Created attachment 170433 [details] [review] Bug 37580: Unique Holidays Description are not editable Holiday names and descriptions are not editable after creation in tools/holiday.pl. This patch corrects this regression. To test: 1) Login to staff client 2) Open Tools -> Calendar 3) Click on a date and create a holiday with name and description. 4) Save holiday. 5) Click on newly created holiday on calendar and edit the name and description. 6) Re-Save Holiday. 7) Click again on holiday, and see that name and description changes did not save. 8) Apply patch 9) Repeat steps 5-7 10) Verify that changes now save. Sponsored-by: Westlake Porter Public Library Signed-off-by: Martha <msulllivan@rcls.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
CSRF related
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06