Bug 37589 - Edit link when receiving orders is not going to the correct page
Summary: Edit link when receiving orders is not going to the correct page
Status: RESOLVED DUPLICATE of bug 37536
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-07 06:09 UTC by wainuiwitikapark
Modified: 2024-08-15 03:47 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description wainuiwitikapark 2024-08-07 06:09:14 UTC
After applying patch from Bug 37533 - when receiving and editing the order - the Edit link to edit the item doesn't return to the correct page, it loads it then goes back to the edit order pop up that the link is on
Comment 1 Nick Clemens (kidclamp) 2024-08-08 12:32:31 UTC
I don't think it is related to 37533, but maybe to somethig underlying

To recreate:
1 - Make sure your system or basket is set to create items when ordering
2 - Add an order to a basket
3 - Close the basket
4 - Receive shipments
5 - Select or create invoice
6 - Select the order
7 - In the receipt modal click the 'Edit' button for the item in the left hand table
8 - A popup is launched, then immediately closes at url:
    http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=76&itemnumber=1114&popup=1#edititem
9 - The link can be opened manually no problem, but when launched via the Edit button it always closes
Comment 2 wainuiwitikapark 2024-08-08 22:39:46 UTC
(In reply to Nick Clemens (kidclamp) from comment #1)
> I don't think it is related to 37533, but maybe to somethig underlying
> 
> To recreate:
> 1 - Make sure your system or basket is set to create items when ordering
> 2 - Add an order to a basket
> 3 - Close the basket
> 4 - Receive shipments
> 5 - Select or create invoice
> 6 - Select the order
> 7 - In the receipt modal click the 'Edit' button for the item in the left
> hand table
> 8 - A popup is launched, then immediately closes at url:
>    
> http://localhost:8081/cgi-bin/koha/cataloguing/additem.
> pl?op=edititem&biblionumber=76&itemnumber=1114&popup=1#edititem
> 9 - The link can be opened manually no problem, but when launched via the
> Edit button it always closes

Hi Nick, thanks for your comment!

I think you are probably correct, I can remove the dependency link.
Comment 3 wainuiwitikapark 2024-08-13 06:58:26 UTC
This issue seems to be to do with the popup=1 part of the url
Comment 4 Brendan Lawlor 2024-08-14 19:58:20 UTC

*** This bug has been marked as a duplicate of bug 37536 ***
Comment 5 Brendan Lawlor 2024-08-14 20:01:54 UTC
(In reply to wainuiwitikapark from comment #3)
> This issue seems to be to do with the popup=1 part of the url

It is indeed when popup=1. The issue is the javascript checks for op = 'saveitem' needs to be updated to op = 'cud-saveitem'
Comment 6 wainuiwitikapark 2024-08-15 03:47:43 UTC
(In reply to Brendan Lawlor from comment #5)
> (In reply to wainuiwitikapark from comment #3)
> > This issue seems to be to do with the popup=1 part of the url
> 
> It is indeed when popup=1. The issue is the javascript checks for op =
> 'saveitem' needs to be updated to op = 'cud-saveitem'

Thanks heaps!!!