This is so that clicking on the label will put the cursor focus on the checkbox. At the moment the label and the checkbox are not semantically 'linked' without an ID
Created attachment 184260 [details] [review] Bug 37604 - Give skip_open_orders checkbox an ID in batch record deletion template To Test: 1. Navigate to Home > Cataloging > Batch record deletion 2. Click 'Skip bibliographic records with open acquisition orders' to toggle the Record type checkbox
Created attachment 184275 [details] [review] Bug 37604: Add an ID to the batch record deletion "Skip biblio...." checkbox This patch adds an ID to the "Skip bibliographic records with open acquisition orders" checkbox on the batch record deletion page (Cataloging > Batch editing > Batch record deletion". This is required so that when selecting or unselecting the checkbox, the focus remains on the checkbox. Test plan: 1. Navigate to Home > Cataloging > Batch record deletion 2. Click 'Skip bibliographic records with open acquisition orders' to toggle the Record type checkbox (selected by default). 3. Inspect the page (right click the page, select Inspect, and look at the values in the checheckbox input field): . before the patch there is no id for the field . after the patch there is an id="skip_open_orders" for the checkbox field Signed-off-by: David Nind <david@davidnind.com>
Thanks for the patch Aman! I've signed off the patch, as it does add an ID to the checkbox. However, I don't exactly understand what is changed or why (I didn't notice any change in behavour) - probably reflecting my lack of accessibility related knowledge! I also updated the commit message (see the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages). I changed the format of the title and added a description - it should describe what problem the patch solves. I've also added a draft release note. This should be updated to reflect what the problem is that it solves. David Nind
Created attachment 184276 [details] [review] Bug 37604: Add an ID to the batch record deletion "Skip biblio...." checkbox This patch adds an ID to the "Skip bibliographic records with open acquisition orders" checkbox on the batch record deletion page (Cataloging > Batch editing > Batch record deletion". This is required so that when selecting or unselecting the checkbox, the focus remains on the checkbox. Test plan: 1. Navigate to Home > Cataloging > Batch record deletion 2. Click 'Skip bibliographic records with open acquisition orders' to toggle the Record type checkbox (selected by default). 3. Inspect the page (right click the page, select Inspect, and look at the values in the checheckbox input field): . before the patch there is no id for the field . after the patch there is an id="skip_open_orders" for the checkbox field Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to David Nind from comment #3) > However, I don't exactly understand what is changed or why (I didn't notice > any change in behavour) - probably reflecting my lack of accessibility > related knowledge! > Thanks David - I half explained it in the description but could be more clear! Adding an ID to semantically link the label to the checkbox is important for those using screen readers or keyboard navigation to interact reliably with the form. Many users will be able to look at the label and checkbox and see that they are laid out next to each other and assume they are related. However, adding the input "id" to match the label "for" tells machines that they are related. Hope that makes sense!
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Pushed to 24.11.x for 24.11.09