Bug 37713 - OAI-PMH - Honour OpacSuppression syspref
Summary: OAI-PMH - Honour OpacSuppression syspref
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Web services (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on: 38330 31161
Blocks: 39337
  Show dependency treegraph
 
Reported: 2024-08-22 23:07 UTC by David Cook
Modified: 2025-05-09 03:16 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 37713: Do not show record metadata if OPAC suppressed (2.00 KB, patch)
2025-03-10 01:27 UTC, David Cook
Details | Diff | Splinter Review
Bug 37713: Do not show record metadata if OPAC suppressed (2.07 KB, patch)
2025-03-10 07:43 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2024-08-22 23:07:39 UTC
Currently, records hidden with OpacSuppression still appear in the OAI-PMH output.
Comment 1 David Cook 2024-10-22 00:09:21 UTC
I may as well mark myself as assignee for this too...
Comment 2 David Cook 2025-02-18 22:44:52 UTC
Going to reset Assignee for now, since this is very low on my list of priorities at the moment...
Comment 3 David Cook 2025-03-10 01:27:37 UTC
Created attachment 179090 [details] [review]
Bug 37713: Do not show record metadata if OPAC suppressed

This change checks the 942$n if OpacSuppression is enabled,
and does not return the record metadata if 942$n is true. See BZ 31161.

Test plan:
0. Apply the patch
1. koha-plack --restart kohadev
2. Enable syspref "OAI-PMH"
3. Set syspref "OpacSuppression" to "Hide"
4. Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc
5. Note KOHA-OAI-TEST:2 metadata visible
6. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=2
7. Set 942$n to "Yes"
8. Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc
9. Note KOHA-OAI-TEST:2 metadata no longer visible and instead "Record Status: deleted" shows
Comment 4 Martin Renvoize (ashimema) 2025-03-10 07:43:24 UTC Comment hidden (obsolete)
Comment 5 David Cook 2025-05-09 03:16:47 UTC
I'm going to fail this and make bug 38330 a dependency