To recreate: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. click on any of the drop down option 4. Nothing happens :(
Created attachment 170728 [details] [review] Bug 37734: Fix insert runtime parameter button in reports To test: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. Click on any of the drop down options 4. Nothing happens :( 5. Apply patch 6. Repeat steps 2 and 3 for all different parameters 7. Notice the modal launches :) 8. Confirm the parameters are inserted as expected
Created attachment 170734 [details] [review] Bug 37734: Fix insert runtime parameter button in reports To test: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. Click on any of the drop down options 4. Nothing happens :( 5. Apply patch 6. Repeat steps 2 and 3 for all different parameters 7. Notice the modal launches :) 8. Confirm the parameters are inserted as expected Signed-off-by: David Nind <david@davidnind.com>
Could you please add a description to the commit message, as per the commit message guidelines? https://wiki.koha-community.org/wiki/Commit_messages#Bug.2Ffeature_description
Created attachment 170739 [details] [review] Bug 37734: Fix insert runtime parameter button in reports The drop down item links had two class attributes which prevented javascript from opening the modal. This patch combines the classes into one class attribute. To test: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. Click on any of the drop down options 4. Nothing happens :( 5. Apply patch 6. Repeat steps 2 and 3 for all different parameters 7. Notice the modal launches :) 8. Confirm the parameters are inserted as expected
Created attachment 170740 [details] [review] Bug 37734: Fix insert runtime parameter button in reports To test: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. Click on any of the drop down options 4. Nothing happens :( 5. Apply patch 6. Repeat steps 2 and 3 for all different parameters 7. Notice the modal launches :) 8. Confirm the parameters are inserted as expected Signed-off-by: David Nind <david@davidnind.com>
Created attachment 170741 [details] [review] Bug 37734: Fix insert runtime parameter button in reports The drop down item links had two class attributes which prevented javascript from opening the modal. This patch combines the classes into one class attribute. To test: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. Click on any of the drop down options 4. Nothing happens :( 5. Apply patch 6. Repeat steps 2 and 3 for all different parameters 7. Notice the modal launches :) 8. Confirm the parameters are inserted as expected Signed-off-by: David Nind <david@davidnind.com>
Thanks Brendan!
(In reply to David Nind from comment #3) > Could you please add a description to the commit message, as per the commit > message guidelines? > https://wiki.koha-community.org/wiki/Commit_messages#Bug. > 2Ffeature_description Thanks for the reminder. I amended the commit and reattached, but I messed something up because it took off your sign off, so I tried again and think I did it correctly the second time around :)
Created attachment 170775 [details] [review] Bug 37734: Fix insert runtime parameter button in reports The drop down item links had two class attributes which prevented javascript from opening the modal. This patch combines the classes into one class attribute. To test: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. Click on any of the drop down options 4. Nothing happens :( 5. Apply patch 6. Repeat steps 2 and 3 for all different parameters 7. Notice the modal launches :) 8. Confirm the parameters are inserted as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Looks good - thanks for the fix! Passing QA
Pushed for 24.11! Well done everyone, thank you!