Bug 37734 - Insert runtime parameter button is not working in Reports
Summary: Insert runtime parameter button is not working in Reports
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Brendan Lawlor
QA Contact: Emily Lamancusa
URL:
Keywords:
Depends on: 35402
Blocks:
  Show dependency treegraph
 
Reported: 2024-08-26 13:47 UTC by Brendan Lawlor
Modified: 2024-08-29 15:25 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the 'Insert runtime parameter' when creating reports from SQL - nothing was happening when selecting any of the parameters to insert. (This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11.)
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37734: Fix insert runtime parameter button in reports (3.72 KB, patch)
2024-08-26 15:06 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 37734: Fix insert runtime parameter button in reports (3.77 KB, patch)
2024-08-26 18:39 UTC, David Nind
Details | Diff | Splinter Review
Bug 37734: Fix insert runtime parameter button in reports (3.72 KB, patch)
2024-08-26 20:27 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 37734: Fix insert runtime parameter button in reports (3.77 KB, patch)
2024-08-26 20:32 UTC, David Nind
Details | Diff | Splinter Review
Bug 37734: Fix insert runtime parameter button in reports (3.93 KB, patch)
2024-08-26 20:32 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 37734: Fix insert runtime parameter button in reports (4.00 KB, patch)
2024-08-27 15:03 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Lawlor 2024-08-26 13:47:07 UTC
To recreate:
1. Go to Reports > Create from SQL
2. Click the Insert runtime parameter button
3. click on any of the drop down option
4. Nothing happens :(
Comment 1 Brendan Lawlor 2024-08-26 15:06:56 UTC
Created attachment 170728 [details] [review]
Bug 37734: Fix insert runtime parameter button in reports

To test:
1. Go to Reports > Create from SQL
2. Click the Insert runtime parameter button
3. Click on any of the drop down options
4. Nothing happens :(
5. Apply patch
6. Repeat steps 2 and 3 for all different parameters
7. Notice the modal launches :)
8. Confirm the parameters are inserted as expected
Comment 2 David Nind 2024-08-26 18:39:54 UTC
Created attachment 170734 [details] [review]
Bug 37734: Fix insert runtime parameter button in reports

To test:
1. Go to Reports > Create from SQL
2. Click the Insert runtime parameter button
3. Click on any of the drop down options
4. Nothing happens :(
5. Apply patch
6. Repeat steps 2 and 3 for all different parameters
7. Notice the modal launches :)
8. Confirm the parameters are inserted as expected

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-08-26 18:44:47 UTC
Could you please add a description to the commit message, as per the commit message guidelines? https://wiki.koha-community.org/wiki/Commit_messages#Bug.2Ffeature_description
Comment 4 Brendan Lawlor 2024-08-26 20:27:49 UTC
Created attachment 170739 [details] [review]
Bug 37734: Fix insert runtime parameter button in reports

The drop down item links had two class attributes which
prevented javascript from opening the modal.
This patch combines the classes into one class attribute.

To test:
1. Go to Reports > Create from SQL
2. Click the Insert runtime parameter button
3. Click on any of the drop down options
4. Nothing happens :(
5. Apply patch
6. Repeat steps 2 and 3 for all different parameters
7. Notice the modal launches :)
8. Confirm the parameters are inserted as expected
Comment 5 David Nind 2024-08-26 20:32:09 UTC Comment hidden (obsolete)
Comment 6 Brendan Lawlor 2024-08-26 20:32:28 UTC
Created attachment 170741 [details] [review]
Bug 37734: Fix insert runtime parameter button in reports

The drop down item links had two class attributes which
prevented javascript from opening the modal.
This patch combines the classes into one class attribute.

To test:
1. Go to Reports > Create from SQL
2. Click the Insert runtime parameter button
3. Click on any of the drop down options
4. Nothing happens :(
5. Apply patch
6. Repeat steps 2 and 3 for all different parameters
7. Notice the modal launches :)
8. Confirm the parameters are inserted as expected

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2024-08-26 20:32:59 UTC
Thanks Brendan!
Comment 8 Brendan Lawlor 2024-08-26 20:35:28 UTC
(In reply to David Nind from comment #3)
> Could you please add a description to the commit message, as per the commit
> message guidelines?
> https://wiki.koha-community.org/wiki/Commit_messages#Bug.
> 2Ffeature_description

Thanks for the reminder. I amended the commit and reattached, but I messed something up because it took off your sign off, so I tried again and think I did it correctly the second time around :)
Comment 9 Emily Lamancusa 2024-08-27 15:03:43 UTC
Created attachment 170775 [details] [review]
Bug 37734: Fix insert runtime parameter button in reports

The drop down item links had two class attributes which
prevented javascript from opening the modal.
This patch combines the classes into one class attribute.

To test:
1. Go to Reports > Create from SQL
2. Click the Insert runtime parameter button
3. Click on any of the drop down options
4. Nothing happens :(
5. Apply patch
6. Repeat steps 2 and 3 for all different parameters
7. Notice the modal launches :)
8. Confirm the parameters are inserted as expected

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 10 Emily Lamancusa 2024-08-27 15:04:21 UTC
Looks good - thanks for the fix! Passing QA
Comment 11 Katrin Fischer 2024-08-29 15:25:22 UTC
Pushed for 24.11!

Well done everyone, thank you!