When a patron has a hold on a title that has a mix of holdable and unholdable items we will not fill the hold if the unholdable items are checked out. This is similar to bug 4850, but that seems to be about the check-in response, this is to solve the checkout handling To recreate: 1 - Set a "Default holds policy by item type" rule on "Mixed materials" to "No holds allowed" 2 - Add a Mixed Materials item on a record with items of 'Book' item types that are holdable 3 - Place a hold for a patron 4 - Check out the 'Mixed material' book to the patron (they are allowed to borrow these materials) 5 - The hold is not marked filled! It is common for libraries to have 'New items' or 'Lucky day' items that are nto holdable, but can be checked out by the patron if found on the shelf. Koha should fill the hold when issuing even if the item would not normally be holdable
Created attachment 170906 [details] [review] Bug 37774: Unit tests
Created attachment 170907 [details] [review] Bug 37774: Make MoveReserve check for patron holds even if none found by CheckReserve This patch moves the check for a patron's holds so that even if CheckReserve does not find the hold due to hold policies it can still be filled. The check will respect 'ConfirmFutureHolds' as per existing tests 1 - Set a "Default holds policy by item type" rule on "Mixed materials" to "No holds allowed" 2 - Add a Mixed Materials item on a record with items of 'Book' item types that are holdable 3 - Place a hold for a patron 4 - Check out the 'Mixed material' book to the patron (they are allowed to borrow these materials) 5 - The hold is not marked filled! Boo 6 - Check in the item and check out again 7 - The hold is filled! Yay 8 - Place another hold for the patron, with a future date set 9 - Checkout the item 10 - The hold is not filled! Yay 11 - Set 'ConfirmFutureHolds' to include the future hold placed above 12 - Checkin and checkout the item 13 - The hold is filled! Yay
Created attachment 171483 [details] [review] Bug 37774: Unit tests Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 171484 [details] [review] Bug 37774: Make MoveReserve check for patron holds even if none found by CheckReserve This patch moves the check for a patron's holds so that even if CheckReserve does not find the hold due to hold policies it can still be filled. The check will respect 'ConfirmFutureHolds' as per existing tests 1 - Set a "Default holds policy by item type" rule on "Mixed materials" to "No holds allowed" 2 - Add a Mixed Materials item on a record with items of 'Book' item types that are holdable 3 - Place a hold for a patron 4 - Check out the 'Mixed material' book to the patron (they are allowed to borrow these materials) 5 - The hold is not marked filled! Boo 6 - Check in the item and check out again 7 - The hold is filled! Yay 8 - Place another hold for the patron, with a future date set 9 - Checkout the item 10 - The hold is not filled! Yay 11 - Set 'ConfirmFutureHolds' to include the future hold placed above 12 - Checkin and checkout the item 13 - The hold is filled! Yay Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Testing notes: Step 5.5 - Apply patch Step 10.5 - Set AllowHoldDateInFuture to Allow