Bug 37809 - Add missing embeds to checkouts endpoints
Summary: Add missing embeds to checkouts endpoints
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Testopia
URL:
Keywords:
: 34701 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-09-02 14:47 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2024-09-03 19:41 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 37809: Add more embed options to checkouts endpoints (1.71 KB, patch)
2024-09-02 15:02 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 37809: (follow-up) Add wrong embed (1.10 KB, patch)
2024-09-02 15:02 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 37809: (follow-up) Remove wrong embed (1.11 KB, patch)
2024-09-02 17:28 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 37809: (follow-up) Allow embedding item.biblio too (1.37 KB, patch)
2024-09-03 19:38 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2024-09-02 14:47:32 UTC 

    


    


      



        
          Comment 1
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2024-09-02 15:02:38 UTC
        

      






Created attachment 170949 [details] [review]
Bug 37809: Add more embed options to checkouts endpoints

This patch adds more embed options to checkouts endpoints.
To test you really need to try them on a REST tool.

* patron
* item
* library

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

    


    


      

          
            
          


        
          Comment 2
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2024-09-02 15:02:40 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      



        
          Comment 3
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2024-09-02 17:28:17 UTC
        

      






Created attachment 170952 [details] [review]
Bug 37809: (follow-up) Remove wrong embed

It seems to me like a copy and paste error coming from the holds
endpoint.

To test:
1. Use a REST API tool like Postman to ask for some patron's checkouts
2. Add x-koha-emebed: cancellation_requested
=> FAIL: It explodes, cannot embed it
3. Apply this patch
4. Repeat 2
=> SUCCESS: cancellation_requested no longer a valid option
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

    


    


      



        
          Comment 4
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2024-09-02 17:28:45 UTC
        

      






Comment on attachment 170950 [details] [review]
Bug 37809: (follow-up) Add wrong embed

s/Add/Remove/

    


    


      



        
          Comment 5
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2024-09-03 19:38:49 UTC
        

      






Created attachment 170999 [details] [review]
Bug 37809: (follow-up) Allow embedding item.biblio too

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

    


    


      



        
          Comment 6
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2024-09-03 19:41:38 UTC
        

      






*** Bug 34701 has been marked as a duplicate of this bug. ***