Created attachment 170949 [details] [review] Bug 37809: Add more embed options to checkouts endpoints This patch adds more embed options to checkouts endpoints. To test you really need to try them on a REST tool. * patron * item * library Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 170950 [details] [review] Bug 37809: (follow-up) Add wrong embed It seems to me like a copy and paste error coming from the holds endpoint. To test: 1. Use a REST API tool like Postman to ask for some patron's checkouts 2. Add x-koha-emebed: cancellation_requested => FAIL: It explodes, cannot embed it 3. Apply this patch 4. Repeat 2 => SUCCESS: cancellation_requested no longer a valid option 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 170952 [details] [review] Bug 37809: (follow-up) Remove wrong embed It seems to me like a copy and paste error coming from the holds endpoint. To test: 1. Use a REST API tool like Postman to ask for some patron's checkouts 2. Add x-koha-emebed: cancellation_requested => FAIL: It explodes, cannot embed it 3. Apply this patch 4. Repeat 2 => SUCCESS: cancellation_requested no longer a valid option 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment on attachment 170950 [details] [review] Bug 37809: (follow-up) Add wrong embed s/Add/Remove/
Created attachment 170999 [details] [review] Bug 37809: (follow-up) Allow embedding item.biblio too Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
*** Bug 34701 has been marked as a duplicate of this bug. ***
Created attachment 174086 [details] [review] Bug 37809: Add more embed options to checkouts endpoints This patch adds more embed options to checkouts endpoints. To test you really need to try them on a REST tool. * patron * item * library Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 174087 [details] [review] Bug 37809: (follow-up) Remove wrong embed It seems to me like a copy and paste error coming from the holds endpoint. To test: 1. Use a REST API tool like Postman to ask for some patron's checkouts 2. Add x-koha-emebed: cancellation_requested => FAIL: It explodes, cannot embed it 3. Apply this patch 4. Repeat 2 => SUCCESS: cancellation_requested no longer a valid option 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 174088 [details] [review] Bug 37809: (follow-up) Allow embedding item.biblio too Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice simple patch with a great enhancement. No regressions.. Passing QA straight!
Pushed for 24.11! Well done everyone, thank you!
Enhancement, no 24.05.x backport.
While technically an enhancement, the 'cancellation_requested' embed before these patches is a bug - please reconsider for backport?