Created attachment 171024 [details] [review] Bug 37830: Add ability to filter holdings in OPAC Test plan: 1) Visit any OPAC biblio page, ktd: opac_url/cgi-bin/koha/opac-detail.pl?biblionumber=336 2) Notice a new "Search holdings" input on top of the holdings table 3) Type something in the input, notice it filters rows 4) Clear the filter, notice all rows show
Created attachment 171031 [details] [review] Bug 37830: Add ability to filter holdings in OPAC Test plan: 1) Visit any OPAC biblio page, ktd: opac_url/cgi-bin/koha/opac-detail.pl?biblionumber=336 2) Notice a new "Search holdings" input on top of the holdings table 3) Type something in the input, notice it filters rows 4) Clear the filter, notice all rows show Signed-off-by: David Nind <david@davidnind.com>
Created attachment 172450 [details] [review] Bug 37830: Add ability to filter holdings in OPAC Test plan: 1) Visit any OPAC biblio page, ktd: opac_url/cgi-bin/koha/opac-detail.pl?biblionumber=336 2) Notice a new "Search holdings" input on top of the holdings table 3) Type something in the input, notice it filters rows 4) Clear the filter, notice all rows show Sponsored-by: NHS England Signed-off-by: David Nind <david@davidnind.com>
Pedro, Is there any reason to not use DataTable's native filter? dom: '<"row-filter"><"clear">lf',
(In reply to Lucas Gass (lukeg) from comment #4) > Pedro, > > Is there any reason to not use DataTable's native filter? > > > dom: '<"row-filter"><"clear">lf', Other than not knowing about it, no reason at all! I've taken a look at this and works very well (and much better than my original patch). I'll revisit. Thanks!
I imagine you've not had a moment to get back to this one yet?
Hi all, our requirements for this particular holdings table search input have grown to customer specific customizations beyond what the datatable search input provides. For this reason I've decided to have my own JavaScript in opacuserjs for this particular use case, for now. I'll follow-up here if community feels this is very valuable to be in core, otherwise I won't proceed with it here.
(In reply to Pedro Amorim from comment #7) > Hi all, our requirements for this particular holdings table search input > have grown to customer specific customizations beyond what the datatable > search input provides. > For this reason I've decided to have my own JavaScript in opacuserjs for > this particular use case, for now. > I'll follow-up here if community feels this is very valuable to be in core, > otherwise I won't proceed with it here. I have to admit that gets me curious about the use case :) Maybe only wondering if we could still use this bug with obsoleted patch to do the datatables standard search filter? This could still be useful for libraries with a lot of items on different branches.