When pressing "Submit" on the "Self Check-in" page with the barcode field left empty, the barcode element still appears in the list. To recreate this bug: Enable the "SelfCheckInModule". Open the page and press the "Submit" button.
Created attachment 171038 [details] [review] Bug 37836 - Prevent submitting empty barcodes in Self check-in
Created attachment 171040 [details] [review] Bug 37836: Prevent submitting empty barcodes in Self check-in This patch disbles the "Submit" button when the barcode field is empty. To test this patch: Add the patch to your koha clone Enable the "SelfCheckInModule". Open the page and the "Submit" button should be disabled when the barcode field is empty. Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Created attachment 172936 [details] [review] Bug 37836: Prevent submitting empty barcodes in Self check-in This patch disbles the "Submit" button when the barcode field is empty. To test this patch: Add the patch to your koha clone Enable the "SelfCheckInModule". Open the page and the "Submit" button should be disabled when the barcode field is empty. Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Seeing some new names here - welcome and thanks for your work!
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Strange this patch added 7 empty lines : +}); + + + + + + + </script> The all file needs some cosmetic review ;)
Pushed to 23.11.x for 23.11.11
Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason.