Bug 37836 - Prevent submitting empty barcodes in self check-in
Summary: Prevent submitting empty barcodes in self check-in
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Bosse
QA Contact: Chris Cormack
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-04 20:01 UTC by Bosse
Modified: 2025-02-03 16:53 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:


Attachments
Bug 37836 - Prevent submitting empty barcodes in Self check-in (1.63 KB, patch)
2024-09-04 20:11 UTC, Bosse
Details | Diff | Splinter Review
Bug 37836: Prevent submitting empty barcodes in Self check-in (1.69 KB, patch)
2024-09-04 23:34 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 37836: Prevent submitting empty barcodes in Self check-in (1.74 KB, patch)
2024-10-17 23:44 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bosse 2024-09-04 20:01:51 UTC
When pressing "Submit" on the "Self Check-in" page with the barcode field left empty, the barcode element still appears in the list.

To recreate this bug:

Enable the "SelfCheckInModule".
Open the page and press the "Submit" button.
Comment 1 Bosse 2024-09-04 20:11:30 UTC
Created attachment 171038 [details] [review]
Bug 37836 - Prevent submitting empty barcodes in Self check-in
Comment 2 Biblibre Sandboxes 2024-09-04 23:34:16 UTC
Created attachment 171040 [details] [review]
Bug 37836: Prevent submitting empty barcodes in Self check-in

This patch disbles the "Submit" button when the barcode field is empty.

To test this patch:

Add the patch to your koha clone
Enable the "SelfCheckInModule".
Open the page and the "Submit" button should be disabled when the barcode field is empty.

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 3 Chris Cormack 2024-10-17 23:44:37 UTC
Created attachment 172936 [details] [review]
Bug 37836: Prevent submitting empty barcodes in Self check-in

This patch disbles the "Submit" button when the barcode field is empty.

To test this patch:

Add the patch to your koha clone
Enable the "SelfCheckInModule".
Open the page and the "Submit" button should be disabled when the barcode field is empty.

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 4 Katrin Fischer 2024-10-18 12:13:21 UTC
Seeing some new names here - welcome and thanks for your work!
Comment 5 Katrin Fischer 2024-10-18 12:27:27 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-11-19 15:56:09 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 7 Fridolin Somers 2024-12-13 13:59:23 UTC
Strange this patch added 7 empty lines :

+});
+
+
+
+
+
+
+
     </script>

The all file needs some cosmetic review ;)
Comment 8 Fridolin Somers 2024-12-13 13:59:56 UTC
Pushed to 23.11.x for 23.11.11
Comment 9 Jesse Maseto 2025-02-03 16:53:49 UTC
Not pushed to LTS. Marked Resolved.

If you feel this should be in LTS please reply with your reason.