(In reply to Jonathan Druart from Bug 36337 comment #6) > Not sure if this is this patch that needs to fix it, but I found a bad > display when en and en-GB are selected: https://snipboard.io/iBNjEn.jpg > (bottom left) The OPAC language menu needs to switch it's alignment relative to the trigger button based on whether it's appearing in the header or the footer.
Created attachment 171060 [details] [review] Bug 37841: Switch OPAC language menu alignment in header and footer The OPAC language menu is now generated by the same include file in both the header and the footer. We have a switch for the menu's direction based on this context, but we also need a switch for alignment: The menu should extend left into the page from the header, and right into the page from the footer. To test you should have at least one additional language installed and enabled. To reproduce the bug I recomment en-GB because the language description is long enough to trigger the misalignment. - Apply the patch and set the 'opaclanguagesdisplay' system preference to "Allow" and the 'OpacLangSelectorMode' preference to "both top and footer". - Go to the OPAC and test the language selector menus in the header and footer. - The expanded menu in the header should extend to the left of the "Languages" menu trigger. - The expanded menu in the footer should extend to the right of the "Languages" menu trigger.
Created attachment 171158 [details] Screenshot - display issue after patch + English United Kingdom language selected The patch fixes the display if English is the language selected. However, if you select 'English United Kingdom', you get the same problem again (see the screenshot)
David did you update and install the en-GB translations after applying the patch? From the screenshot it looks like the en-GB templates don't have the patch's changes.
(In reply to Owen Leonard from comment #3) > David did you update and install the en-GB translations after applying the > patch? From the screenshot it looks like the en-GB templates don't have the > patch's changes. That was indeed the problem! Sign off on the way...
Created attachment 171230 [details] [review] Bug 37841: Switch OPAC language menu alignment in header and footer The OPAC language menu is now generated by the same include file in both the header and the footer. We have a switch for the menu's direction based on this context, but we also need a switch for alignment: The menu should extend left into the page from the header, and right into the page from the footer. To test you should have at least one additional language installed and enabled. To reproduce the bug I recomment en-GB because the language description is long enough to trigger the misalignment. - Apply the patch and set the 'opaclanguagesdisplay' system preference to "Allow" and the 'OpacLangSelectorMode' preference to "both top and footer". - Go to the OPAC and test the language selector menus in the header and footer. - The expanded menu in the header should extend to the left of the "Languages" menu trigger. - The expanded menu in the footer should extend to the right of the "Languages" menu trigger. Signed-off-by: David Nind <david@davidnind.com>
To test bug 36337 I need to apply bug 37833 and this one, but I get a conflict: Bug 36337 Depends on bug 37833 (Signed Off) Follow? [(y)es, (n)o] Bug 37833 - Incorrect logic controlling display of OPAC language selection menus 171154 - Bug 37833: Incorrect logic controlling display of OPAC language selection menus Applying: Bug 37833: Incorrect logic controlling display of OPAC language selection menus Apply? [(y)es, (n)o, (i)nteractive] Bug 36337 Depends on bug 37841 (Signed Off) Follow? [(y)es, (n)o] Bug 37841 - Switch OPAC language menu alignment in header and footer 171230 - Bug 37841: Switch OPAC language menu alignment in header and footer Applying: Bug 37841: Switch OPAC language menu alignment in header and footer Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc
Created attachment 171345 [details] [review] Bug 37841: Switch OPAC language menu alignment in header and footer The OPAC language menu is now generated by the same include file in both the header and the footer. We have a switch for the menu's direction based on this context, but we also need a switch for alignment: The menu should extend left into the page from the header, and right into the page from the footer. To test you should have at least one additional language installed and enabled. To reproduce the bug I recomment en-GB because the language description is long enough to trigger the misalignment. - Apply the patch and set the 'opaclanguagesdisplay' system preference to "Allow" and the 'OpacLangSelectorMode' preference to "both top and footer". - Go to the OPAC and test the language selector menus in the header and footer. - The expanded menu in the header should extend to the left of the "Languages" menu trigger. - The expanded menu in the footer should extend to the right of the "Languages" menu trigger. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 171356 [details] [review] Bug 37841: Switch OPAC language menu alignment in header and footer The OPAC language menu is now generated by the same include file in both the header and the footer. We have a switch for the menu's direction based on this context, but we also need a switch for alignment: The menu should extend left into the page from the header, and right into the page from the footer. To test you should have at least one additional language installed and enabled. To reproduce the bug I recomment en-GB because the language description is long enough to trigger the misalignment. - Apply the patch and set the 'opaclanguagesdisplay' system preference to "Allow" and the 'OpacLangSelectorMode' preference to "both top and footer". - Go to the OPAC and test the language selector menus in the header and footer. - The expanded menu in the header should extend to the left of the "Languages" menu trigger. - The expanded menu in the footer should extend to the right of the "Languages" menu trigger. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed for 24.11! Well done everyone, thank you!