For styling and customizing, it would be nice to have classes for more of the sco renewal and hold statuses
Created attachment 171246 [details] [review] Bug 37882: Add class for statuses to SCO module for holds and renewals This patch should have no visual impact, but will add several classes To test: 1 - Place some holds and checkout items to a patron Ensure some items cannot renew, and set a hold with a library as pickup location, then unset library as a location in Library admin page 2 - View their record in sco 3 - Apply patch 4 - 'Finish' and start a new SCO session as same user 5 - No visual difference 6 - Inspect issues/hold to see if new psans are present
Created attachment 171262 [details] [review] Bug 37882: Add class for statuses to SCO module for holds and renewals This patch should have no visual impact, but will add several classes To test: 1 - Place some holds and checkout items to a patron Ensure some items cannot renew, and set a hold with a library as pickup location, then unset library as a location in Library admin page 2 - View their record in sco 3 - Apply patch 4 - 'Finish' and start a new SCO session as same user 5 - No visual difference 6 - Inspect issues/hold to see if new psans are present Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Thanks Nick, these patches are tremendously helpful for styling/changing text of certain error messages.
Ooh, this is a great addition! Since this is a string patch that is partly for users, I am going to nitpick the strings a bit, though... Do the classes need to exactly match the reason codes passed to the template? If not, I'd argue for the following changes for better consistency: 1. The classes should match our vocabulary conventions (for example, toomanyholdstoday instead of toomanyreservestoday) 2. Consistent use of underscores in class names These don't have to be a blocker if there's a good reason to keep it as-is, but if we can have more consistency that will make it easier for users to write their own customizations, then I think we should. Setting to FQA for feedback.