Bug 37920 - writeoff_debts.pl should be logged
Summary: writeoff_debts.pl should be logged
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
: 38244 (view as bug list)
Depends on: 39236
Blocks:
  Show dependency treegraph
 
Reported: 2024-09-13 14:32 UTC by Andrew Fuerste-Henry
Modified: 2025-03-23 14:14 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00,24.11.03
Circulation function:


Attachments
Bug 37920: Add cronjob loggging to writeoff_debts.pl (1.43 KB, patch)
2025-03-04 14:06 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 37920: Add cronjob loggging to writeoff_debts.pl (1.53 KB, patch)
2025-03-11 08:46 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 37920: Add cronjob loggging to writeoff_debts.pl (1.60 KB, patch)
2025-03-11 11:05 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2024-09-13 14:32:12 UTC
Runs of the writeoff_debts cron are not logged in the action logs. They should be.
Comment 1 Nick Clemens (kidclamp) 2025-03-04 14:05:52 UTC
*** Bug 38244 has been marked as a duplicate of this bug. ***
Comment 2 Nick Clemens (kidclamp) 2025-03-04 14:06:22 UTC Comment hidden (obsolete)
Comment 3 Magnus Enger 2025-03-11 08:46:22 UTC
Created attachment 179144 [details] [review]
Bug 37920: Add cronjob loggging to writeoff_debts.pl

This patch adds the same logging as other cronjobs have

To test:
1 - Enable system preference CronjobLog
2 - perl misc/cronjobs/writeoff_debts.pl -v -c --added-after 2025-01-01
3 - Check the logs - no entries
4 - Apply patch
5 - Repeat 2
6 - Check the logs, two entries - one for the start and one for the end

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Tested on top of bug 39236. Works as advertised.
Comment 4 Martin Renvoize (ashimema) 2025-03-11 11:05:40 UTC
Created attachment 179156 [details] [review]
Bug 37920: Add cronjob loggging to writeoff_debts.pl

This patch adds the same logging as other cronjobs have

To test:
1 - Enable system preference CronjobLog
2 - perl misc/cronjobs/writeoff_debts.pl -v -c --added-after 2025-01-01
3 - Check the logs - no entries
4 - Apply patch
5 - Repeat 2
6 - Check the logs, two entries - one for the start and one for the end

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Tested on top of bug 39236. Works as advertised.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2025-03-17 07:28:09 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 6 Paul Derscheid 2025-03-23 14:09:16 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.03