Bug 37927 - Show report name on page title when viewing SQL
Summary: Show report name on page title when viewing SQL
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Leo Stoyanov
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2024-09-15 21:43 UTC by Aleisha Amohia
Modified: 2025-01-28 01:57 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the browser window/tab page title when viewing the SQL for a report (Reports > Saved reports > Actions > View) - it now includes the report name and number.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 37927: Fixed report name on page title not showing up when viewing SQL (1.30 KB, patch)
2025-01-07 17:02 UTC, Leo Stoyanov
Details | Diff | Splinter Review
Bug 37927: Fixed report name on page title not showing up when viewing SQL (1.37 KB, patch)
2025-01-07 17:48 UTC, Imani
Details | Diff | Splinter Review
Bug 37927: Fixed report name on page title not showing up when viewing SQL (1.44 KB, patch)
2025-01-08 15:41 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2024-09-15 21:43:43 UTC
The name of the report doesn't show in the page title (the browser window or tab title) when viewing SQL, i.e. the URL is /cgi-bin/koha/reports/guided_reports.pl?reports=162&phase=Show SQL
Comment 1 Lucas Gass (lukeg) 2024-10-25 15:51:53 UTC
(In reply to Aleisha Amohia from comment #0)
> The name of the report doesn't show in the page title (the browser window or
> tab title) when viewing SQL, i.e. the URL is
> /cgi-bin/koha/reports/guided_reports.pl?reports=162&phase=Show SQL

Aleisha, I think this URL may have changed since when you filed this? I could be wrong. 

Is this now /cgi-bin/koha/reports/guided_reports.pl?id=162&op=run ?
Comment 2 Aleisha Amohia 2024-10-29 00:00:02 UTC
Hi Luke, no this one is still valid. I'm referring to when we're viewing SQL, not when running a report.

Foe example if you go to your saved reports, then click the Actions drop-up menu, then click View SQL.

You're right that the URL has changed though, it is now this: /cgi-bin/koha/reports/guided_reports.pl?id=1&op=show

It would be great to show the report name on the tab title here.
Comment 3 Leo Stoyanov 2025-01-07 17:02:45 UTC
Created attachment 176209 [details] [review]
Bug 37927: Fixed report name on page title not showing up when viewing SQL

To test:
1. Create a SQL report.
2. Go to /cgi-bin/koha/reports/guided_reports.pl?id=1&op=show.
3. Inspect element the page, go to the head, and find the title; it should have no report name or id.
4. Apply patch.
5. Redo steps 1-3 to see the fix.
Comment 4 Imani 2025-01-07 17:48:58 UTC
Created attachment 176210 [details] [review]
Bug 37927: Fixed report name on page title not showing up when viewing SQL

To test:
1. Create a SQL report.
2. Go to /cgi-bin/koha/reports/guided_reports.pl?id=1&op=show.
3. Inspect element the page, go to the head, and find the title; it should have no report name or id.
4. Apply patch.
5. Redo steps 1-3 to see the fix.

Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com>
Comment 5 Emily Lamancusa (emlam) 2025-01-08 15:41:12 UTC
Created attachment 176242 [details] [review]
Bug 37927: Fixed report name on page title not showing up when viewing SQL

To test:
1. Create a SQL report.
2. Go to /cgi-bin/koha/reports/guided_reports.pl?id=1&op=show.
3. Inspect element the page, go to the head, and find the title; it should have no report name or id.
4. Apply patch.
5. Redo steps 1-3 to see the fix.

Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 6 Emily Lamancusa (emlam) 2025-01-08 15:42:35 UTC
Nice work, thanks Leo! Passing QA and switching this from an enhancement to a bug, because it is really an accessibility bug.
Comment 7 Katrin Fischer 2025-01-10 18:20:51 UTC
Pushed for 25.05!

Well done everyone, thank you!