The name of the report doesn't show in the page title (the browser window or tab title) when viewing SQL, i.e. the URL is /cgi-bin/koha/reports/guided_reports.pl?reports=162&phase=Show SQL
(In reply to Aleisha Amohia from comment #0) > The name of the report doesn't show in the page title (the browser window or > tab title) when viewing SQL, i.e. the URL is > /cgi-bin/koha/reports/guided_reports.pl?reports=162&phase=Show SQL Aleisha, I think this URL may have changed since when you filed this? I could be wrong. Is this now /cgi-bin/koha/reports/guided_reports.pl?id=162&op=run ?
Hi Luke, no this one is still valid. I'm referring to when we're viewing SQL, not when running a report. Foe example if you go to your saved reports, then click the Actions drop-up menu, then click View SQL. You're right that the URL has changed though, it is now this: /cgi-bin/koha/reports/guided_reports.pl?id=1&op=show It would be great to show the report name on the tab title here.
Created attachment 176209 [details] [review] Bug 37927: Fixed report name on page title not showing up when viewing SQL To test: 1. Create a SQL report. 2. Go to /cgi-bin/koha/reports/guided_reports.pl?id=1&op=show. 3. Inspect element the page, go to the head, and find the title; it should have no report name or id. 4. Apply patch. 5. Redo steps 1-3 to see the fix.
Created attachment 176210 [details] [review] Bug 37927: Fixed report name on page title not showing up when viewing SQL To test: 1. Create a SQL report. 2. Go to /cgi-bin/koha/reports/guided_reports.pl?id=1&op=show. 3. Inspect element the page, go to the head, and find the title; it should have no report name or id. 4. Apply patch. 5. Redo steps 1-3 to see the fix. Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com>
Created attachment 176242 [details] [review] Bug 37927: Fixed report name on page title not showing up when viewing SQL To test: 1. Create a SQL report. 2. Go to /cgi-bin/koha/reports/guided_reports.pl?id=1&op=show. 3. Inspect element the page, go to the head, and find the title; it should have no report name or id. 4. Apply patch. 5. Redo steps 1-3 to see the fix. Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Nice work, thanks Leo! Passing QA and switching this from an enhancement to a bug, because it is really an accessibility bug.
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.04
Not backporting to 22.11.x as it wasn't backported to 24.05.x