37928 – "Upload image" item not correctly styled

Bug 37928 - "Upload image" item not correctly styled

Summary: "Upload image" item not correctly styled

Status:	Needs documenting

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Staff interface (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P5 - low minor
Assignee:	Jonathan Druart
QA Contact:	Lucas Gass (lukeg)

URL:
Keywords:

Depends on:	35402
Blocks:
	Show dependency tree / graph

Reported:	2024-09-16 10:28 UTC by Jonathan Druart
Modified:	2024-12-11 14:23 UTC (History)
CC List:	4 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	24.11.00,24.05.06
Circulation function:

Attachments
Bug 37928: Add missing dropdown-item class to "Upload image" (2.06 KB, patch) 2024-09-16 10:30 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 37928: Add missing dropdown-item class to "Upload image" (2.11 KB, patch) 2024-09-17 01:52 UTC, Phil Ringnalda	Details \| Diff \| Splinter Review
Bug 37928: Add missing dropdown-item class to "Upload image" (2.17 KB, patch) 2024-09-23 22:17 UTC, Lucas Gass (lukeg)	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2024-09-16 10:28:27 UTC

Comment 1 Jonathan Druart 2024-09-16 10:30:17 UTC

Created attachment 171525 [details] [review]
Bug 37928: Add missing dropdown-item class to "Upload image"

"Upload image" item not correctly styled

Test plan:
Go to the bib detail page with at least one item.
Open the action dropdown list and notice the "Upload image" is correctly
styled with this patch

Comment 2 Phil Ringnalda 2024-09-17 01:52:22 UTC

Created attachment 171600 [details] [review]
Bug 37928: Add missing dropdown-item class to "Upload image"

"Upload image" item not correctly styled

Test plan:
Go to the bib detail page with at least one item.
Open the action dropdown list and notice the "Upload image" is correctly
styled with this patch

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Comment 3 Lucas Gass (lukeg) 2024-09-23 22:15:13 UTC

Testing note: must turn on local cover images to see the dropdown button

Comment 4 Lucas Gass (lukeg) 2024-09-23 22:17:12 UTC

Created attachment 171903 [details] [review]
Bug 37928: Add missing dropdown-item class to "Upload image"

"Upload image" item not correctly styled

Test plan:
Go to the bib detail page with at least one item.
Open the action dropdown list and notice the "Upload image" is correctly
styled with this patch

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Comment 5 Martin Renvoize (ashimema) 2024-10-02 09:56:35 UTC

Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant

Comment 6 Lucas Gass (lukeg) 2024-11-18 22:46:17 UTC

Backported to 24.05.x for upcoming 24.05.06

Comment 7 Fridolin Somers 2024-12-11 14:23:21 UTC

Looks like dependancy on Bug 35402 is not that strong, backport to 24.05.x seems OK even without 35402

Not for 23.11.x that does not have this file