When clicking on subsections in the left-hand side menu in system preferences, the screen goes down a bit, but not to the section. To recreate: 1. Go to Administration > System preferences 2. Click Circulation in the left menu (for example) 3. Click Holds policy in the left menu (for example) --> Screen goes down a couple of lines to Article requests (?)
If it helps, I'm using KTD with Chrome on Ubuntu 22.04
I'm using Edge (because employer) and am not able to replicate this--it seems to be working for me on our 24.05.03 catalog and also on ByWater's 24.05.03 demo. So, maybe something broke after 24.05.03?
I've tested on main with Firefox, Chromium, and Google Chrome (all on Ubuntu 22.04) - can confirm Caroline's findings in the description. Other things noted: 1. From system preference search results, the links to "View all XXX preferences" seems to work OK, but not when browsing (as per the bug description). 2. Everything works as expected in a demo 24.05.03, so definitely something added after this to main. Maybe Bug 35402 - Update the OPAC and staff interface to Bootstrap 5 (have linked in case it is related to that).
Can confirm that things were working as expected before the Bootstrap 5 update, but not after: 1. Checkout before the Bootstrap 5 patches: git checkout f44d2cccc7 2. Rebuild the CSS: yarn build 3. Restart everything: restart_all 4. Check that everything works as expected - see description 5. Checkout after the Bootstrap 5 patches: git checkout 764162cd6 6. Rebuild the CSS: yarn build 7. Restart everything: restart_all 8. Check that links are not working as expected - see description
Thanks for confirming David! I figured it was a BS5 bug (I thought it was too weird a bug to be something else), but hadn't done the in-depth research you did. Thanks!
It works if I remove: js/pages/preferences.js 211 $("table.preferences").dataTable( 212 $.extend(true, {}, dataTablesDefaults, { 213 dom: "t", 214 columnDefs: [{ targets: [-1], orderable: false, searchable: false }], 215 paging: false, 216 }) 217 );
Created attachment 172572 [details] [review] Bug 37945: Fix scroll on syspref page
I cannot investigate more right more, but this patch is fixing the problem. It seems good enough for now, not sure we need the other DT's defaults.
Created attachment 172573 [details] [review] Bug 37945: Remove fixedHeader for sysprefs It breaks the scroll when a subsection is clicked.
Ok found it, it's actually the fixedHeader.
Created attachment 172576 [details] [review] Bug 37945: Remove fixedHeader for sysprefs It breaks the scroll when a subsection is clicked. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
THANK YOU!!!
Thanks Jonathan and Caroline!
Good solution, works perfectly.
Created attachment 172666 [details] [review] Bug 37945: Remove fixedHeader for sysprefs It breaks the scroll when a subsection is clicked. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed for 24.11! Well done everyone, thank you!