To recreate: 1. Create a patron attribute. 2. Check it as Mandatory. 3. Do NOT make it display or editable in the OPAC. 4. Go to OPAC self reg form 5. You will not see the attribute. 6. Submit the form and see the 500 error: Missing mandatory extended attribute (type=MANDO) at /usr/share/perl5/Exception/Class/Base.pm line 88
Created attachment 171956 [details] [review] Bug 38005: Pass opac_editable to search params when interface is OPAC 1. Create a patron attribute. 2. Check it as Mandatory. 3. Do NOT make it display or editable in the OPAC. 4. Go to OPAC self reg form 5. You will not see the attribute. 6. Submit the form and see the 500 error. 7. Apply patch, restart_all. 8. Try again, now you should be able to submit the OPAC form.
Created attachment 172501 [details] [review] Bug 38005: Pass opac_editable to search params when interface is OPAC 1. Create a patron attribute. 2. Check it as Mandatory. 3. Do NOT make it display or editable in the OPAC. 4. Go to OPAC self reg form 5. You will not see the attribute. 6. Submit the form and see the 500 error. 7. Apply patch, restart_all. 8. Try again, now you should be able to submit the OPAC form. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 172504 [details] [review] Bug 38005: Pass opac_editable to search params when interface is OPAC 1. Create a patron attribute. 2. Check it as Mandatory. 3. Do NOT make it display or editable in the OPAC. 4. Go to OPAC self reg form 5. You will not see the attribute. 6. Submit the form and see the 500 error. 7. Apply patch, restart_all. 8. Try again, now you should be able to submit the OPAC form. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 172513 [details] [review] Bug 38005: Pass opac_editable to search params when interface is OPAC 1. Create a patron attribute. 2. Check it as Mandatory. 3. Do NOT make it display or editable in the OPAC. 4. Go to OPAC self reg form 5. You will not see the attribute. 6. Submit the form and see the 500 error. 7. Apply patch, restart_all. 8. Try again, now you should be able to submit the OPAC form. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Should we add a note about the change in the code? It might cause confusion later on.
Pushed for 24.11! Well done everyone, thank you!
I am sorry, but this breaks the tests: t_db_dependent_Koha_Patron_t.extended_attributes Please fix urgently, lots of enh waiting.
Created attachment 172702 [details] [review] Bug 38005: (follow-up) Add/adjust tests
Created attachment 172784 [details] [review] Bug 38005: (follow-up) Add/adjust tests NC amended patch, tidied Bug 38005: (QA follow-up) Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(In reply to Katrin Fischer from comment #10) > Pushed for 24.11! > > Well done everyone, thank you! Removing additional_work_needed as the tests have been fixed.
(In reply to Pedro Amorim from comment #11) > (In reply to Katrin Fischer from comment #10) > > Pushed for 24.11! > > > > Well done everyone, thank you! > > Removing additional_work_needed as the tests have been fixed. D11 just died... so I am hopeful, but not sure what's going on there...
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11
Not pushed to LTS(22.11.x). Marked Resolved. If you feel this should be in LTS(22.11.x) please reply with your reason.