Bug 38043 - KohaTimes filter is missing tests
Summary: KohaTimes filter is missing tests
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: CJ Lynce
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on: 36594
Blocks:
  Show dependency tree / graph
 
Reported: 2024-09-30 17:22 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2024-11-18 22:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 38043: Add unit tests for KohaTimes TT filter (2.62 KB, patch)
2024-10-03 15:24 UTC, CJ Lynce 		Details | Diff | Splinter Review
Bug 38043: Add unit tests for KohaTimes TT filter (2.63 KB, patch)
2024-10-04 11:56 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 38043: Add unit tests for KohaTimes TT filter (2.68 KB, patch)
2024-10-07 17:29 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2024-09-30 17:22:09 UTC 
Bug 36594 introduced a new template filter, but didn't provide tests.

Full code and use cases coverage is expected.
Comment 1 CJ Lynce 2024-10-03 15:24:34 UTC 
Created attachment 172362 [details] [review]
Bug 38043: Add unit tests for KohaTimes TT filter

This adds units tests for the new KohaTimes TT filter.
This also corrects a minor issue with a wrong comparitor operation in
    KohaTimes.pm causing a WARN to be thrown.

To test
1. Apply patch
2. prove t/db_dependent/Template/Plugin/KohaTimes.t
3. Verify 5 Tests PASS
Comment 2 Tomás Cohen Arazi (tcohen) 2024-10-04 11:56:54 UTC 
Created attachment 172387 [details] [review]
Bug 38043: Add unit tests for KohaTimes TT filter

This adds units tests for the new KohaTimes TT filter.
This also corrects a minor issue with a wrong comparitor operation in
    KohaTimes.pm causing a WARN to be thrown.

To test
1. Apply patch
2. prove t/db_dependent/Template/Plugin/KohaTimes.t
3. Verify 5 Tests PASS
Comment 3 Lucas Gass (lukeg) 2024-10-07 17:29:55 UTC 
Created attachment 172497 [details] [review]
Bug 38043: Add unit tests for KohaTimes TT filter

This adds units tests for the new KohaTimes TT filter.
This also corrects a minor issue with a wrong comparitor operation in
    KohaTimes.pm causing a WARN to be thrown.

To test
1. Apply patch
2. prove t/db_dependent/Template/Plugin/KohaTimes.t
3. Verify 5 Tests PASS

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-10-11 08:45:12 UTC 
I LOVE tests :)
Comment 5 Katrin Fischer 2024-10-11 09:15:47 UTC 
Pushed for 24.11!

Well done everyone, thank you!