To recreate: 1. Add Patron messaging preferences to `CollapseFieldsPatronAddForm` system preference. 2. Go to a patron record, new or existing. 3. Scroll down to the message pref section and see `Loading new messaging defaults `. 4. It never loads If the fieldset is collapsed we shouldn't load the table but we also shouldn't show a message saying `Loading new messaging defaults...`
*** Bug 39047 has been marked as a duplicate of this bug. ***
Created attachment 178100 [details] [review] Bug 38045: Don't show loading message when hiding messaging preferences This spinner is meant to show when the category has changed and we are loading the new defaults for a category. There is no reason to toggle visibility when the form is initially hidden To test: 1 - Mark 'Patron messaging preference' in CollapseFieldsPatronAddForm 2 - Edit an existing patron or add a new one 3 - Note the spinner 'Loading new messaging preferences' 4 - Click the toggle to hide/show messaging preferences a few times 5 - Spinner disappears and table can be shown 6 - Apply patch 7 - Edit existing or add new patron 8 - No spinner 9 - Change patorn category and say yes to laod new prefs 10 - Note spinner shows and then hides very fast It is easier to see if you collapse all the fields between category and messaing prefs 11 - Confirm messaging prefs can be edited/saved correctly still
I'm getting the sha1/fake ancestor error when trying to apply the patch 8-(... git bz apply 38045 Bug 38045 - Patron messaging preference table says it is loading but never does if fieldset is collapsed 178100 - Bug 38045: Don't show loading message when hiding messaging preferences Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38045: Don't show loading message when hiding messaging preferences error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt). error: could not build fake ancestor Patch failed at 0001 Bug 38045: Don't show loading message when hiding messaging preferences
Maybe bug 39189 fixed this, but I can no longer recreate