In the process of documenting bug 35169 and I think the system preferences should be with the other "DefaultLongOverdueXYZ" system preferences. I also think the description sentence is misleading, as it doesn't change the fact that patron "receive overdues" or not. It's if their checkouts are marked as long overdue or not.
Created attachment 172281 [details] [review] Bug 38053: Change section of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences This patch moves the DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences to the Lost item policy section of the circulation preferences, to be with the other DefaultLongOverdue system preferences. To test: 1. Apply patch 2. Go to Administration > System preferences > Circulation > Lost item policy --> The two system preferences should be there with the other ones
Created attachment 172282 [details] [review] Bug 38053: Change description of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences This patch changes the description of the DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences to make it clearer it has to do with the **long overdues** process and not just the overdues process. It also highlights the warning by making it bold. To test: 1. Apply patch 2. Go to Administration > System preferences > Circulation > Lost item policy 3. Read the description for efaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories, make sure it makes sense, that the grammar and spelling is OK
I submitted something. Open to suggestions. :) I also separated the section change and the description change. That way if one of the two is OK but not the other one, we can obsolete one only (I think?).
Created attachment 172482 [details] [review] Bug 38053: Change description of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences This patch changes the description of the DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences to make it clearer it has to do with the **long overdues** process and not just the overdues process. It also highlights the warning by making it bold. To test: 1. Apply patch 2. Go to Administration > System preferences > Circulation > Lost item policy 3. Read the description for efaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories, make sure it makes sense, that the grammar and spelling is OK Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Thanks for catching this! Your rewording seems clear to me.
Created attachment 172492 [details] [review] Bug 38053: Change description of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences This patch changes the description of the DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences to make it clearer it has to do with the **long overdues** process and not just the overdues process. It also highlights the warning by making it bold. To test: 1. Apply patch 2. Go to Administration > System preferences > Circulation > Lost item policy 3. Read the description for efaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories, make sure it makes sense, that the grammar and spelling is OK Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>