Bug 38053 - Change section and description of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences
Summary: Change section and description of DefaultLongOverduePatronCategories and Defa...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Caroline Cyr La Rose
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on: 35169
Blocks:
  Show dependency tree / graph
 
Reported: 2024-10-01 15:10 UTC by Caroline Cyr La Rose
Modified: 2024-11-18 23:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement moves the DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences to the Lost item policy section of the circulation preferences, to be with the other DefaultLongOverdue system preferences. It also changes the description of the system preferences to make it clearer it has to do with the **long overdues** process and not just the overdues process.
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 38053: Change section of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences (4.67 KB, patch)
2024-10-01 15:30 UTC, Caroline Cyr La Rose 		Details | Diff | Splinter Review
Bug 38053: Change description of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences (3.86 KB, patch)
2024-10-01 15:30 UTC, Caroline Cyr La Rose 		Details | Diff | Splinter Review
Bug 38053: Change description of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences (3.91 KB, patch)
2024-10-07 15:46 UTC, ByWater Sandboxes 		Details | Diff | Splinter Review
Bug 38053: Change description of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences (3.97 KB, patch)
2024-10-07 16:05 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-10-01 15:10:51 UTC 
In the process of documenting bug 35169 and I think the system preferences should be with the other "DefaultLongOverdueXYZ" system preferences. I also think the description sentence is misleading, as it doesn't change the fact that patron "receive overdues" or not. It's if their checkouts are marked as long overdue or not.
Comment 1 Caroline Cyr La Rose 2024-10-01 15:30:10 UTC 
Created attachment 172281 [details] [review]
Bug 38053: Change section of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences

This patch moves the DefaultLongOverduePatronCategories and
DefaultLongOverdueSkipPatronCategories system preferences to
the Lost item policy section of the circulation preferences,
to be with the other DefaultLongOverdue system preferences.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation > Lost
   item policy
   --> The two system preferences should be there with the other
       ones
Comment 2 Caroline Cyr La Rose 2024-10-01 15:30:39 UTC 
Created attachment 172282 [details] [review]
Bug 38053: Change description of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences

This patch changes the description of the DefaultLongOverduePatronCategories
and DefaultLongOverdueSkipPatronCategories system preferences
to make it clearer it has to do with the **long overdues** process
and not just the overdues process. It also highlights the
warning by making it bold.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation >
   Lost item policy
3. Read the description for efaultLongOverduePatronCategories
   and DefaultLongOverdueSkipPatronCategories, make sure it
   makes sense, that the grammar and spelling is OK
Comment 3 Caroline Cyr La Rose 2024-10-01 15:31:59 UTC 
I submitted something. Open to suggestions. :)

I also separated the section change and the description change. That way if one of the two is OK but not the other one, we can obsolete one only (I think?).
Comment 4 ByWater Sandboxes 2024-10-07 15:46:56 UTC 
Created attachment 172482 [details] [review]
Bug 38053: Change description of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences

This patch changes the description of the DefaultLongOverduePatronCategories
and DefaultLongOverdueSkipPatronCategories system preferences
to make it clearer it has to do with the **long overdues** process
and not just the overdues process. It also highlights the
warning by making it bold.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation >
   Lost item policy
3. Read the description for efaultLongOverduePatronCategories
   and DefaultLongOverdueSkipPatronCategories, make sure it
   makes sense, that the grammar and spelling is OK

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 5 Andrew Fuerste-Henry 2024-10-07 15:47:32 UTC 
Thanks for catching this! Your rewording seems clear to me.
Comment 6 Lucas Gass (lukeg) 2024-10-07 16:05:36 UTC 
Created attachment 172492 [details] [review]
Bug 38053: Change description of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences

This patch changes the description of the DefaultLongOverduePatronCategories
and DefaultLongOverdueSkipPatronCategories system preferences
to make it clearer it has to do with the **long overdues** process
and not just the overdues process. It also highlights the
warning by making it bold.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation >
   Lost item policy
3. Read the description for efaultLongOverduePatronCategories
   and DefaultLongOverdueSkipPatronCategories, make sure it
   makes sense, that the grammar and spelling is OK

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 7 Katrin Fischer 2024-10-21 13:12:54 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 8 Lucas Gass (lukeg) 2024-11-18 23:02:20 UTC 
Enhancement, no 24.05.x backport