Created attachment 172290 [details] screenshot of bug The MARC21 XSLT templates typically have a space between their label and the MARC field's value but today I noticed that the label for 530 "Available additional physical forms" does not have a trailing space (see screenshot). To test: - Find a record with a 530 field or add a 530 to an existing record - View record in OPAC — note no space between label and value - Apply patch - View record in OPAC — space is present
Created attachment 172291 [details] [review] Bug 38055: Space between label and value for MARC field 530
Created attachment 172701 [details] No space after the label. I tested this and there does not appear to be a space after the label. Result image attached.
(In reply to Esther Melander from comment #2) > Created attachment 172701 [details] > No space after the label. > > I tested this and there does not appear to be a space after the label. > Result image attached. Esther—did you restart Plack in between applying the patch and testing? That's `koha-plack --restart` (at least it is in a ktd shell). Sorry, that is my mistake, I should have it in the testing plan. If you did restart Plack, then I'll have to revisit this, since when I test locally I see the space.
Yes, I tested in a sandbox and restarted services, which restarted Plack. There is no space between the label and the text in the OPAC.
Created attachment 172995 [details] [review] Bug 38055: Space between label and value for MARC field 530 To test: - Find a record with a 530 field or add a 530 to an existing record - View record in OPAC — note no space between label and value - Apply patch - Restart Plack - View record in OPAC — space is present
(In reply to Esther Melander from comment #4) > Yes, I tested in a sandbox and restarted services, which restarted Plack. > There is no space between the label and the text in the OPAC. Hi Esther, could you try again? I think perhaps my patch wasn't formatted correctly. I remade the patch with `git bz` and now when I test using the ByWater sandboxes I see a space after the colon.
Created attachment 172996 [details] [review] Bug 38055: Space between label and value for MARC field 530 To test: - Find a record with a 530 field or add a 530 to an existing record - View record in OPAC — note no space between label and value - Apply patch - Restart Plack - View record in OPAC — space is present Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 173390 [details] [review] Bug 38055: Space between label and value for MARC field 530 To test: - Find a record with a 530 field or add a 530 to an existing record - View record in OPAC — note no space between label and value - Apply patch - Restart Plack - View record in OPAC — space is present Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed for 24.11! Well done everyone, thank you!