Bug 38055 - Space between label and value for MARC field 530
Summary: Space between label and value for MARC field 530
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Eric Phetteplace
QA Contact: Tomás Cohen Arazi (tcohen)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-01 22:10 UTC by Eric Phetteplace
Modified: 2024-12-05 18:21 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
screenshot of bug (22.86 KB, image/png)
2024-10-01 22:10 UTC, Eric Phetteplace
Details
Bug 38055: Space between label and value for MARC field 530 (2.77 KB, patch)
2024-10-01 22:18 UTC, Eric Phetteplace
Details | Diff | Splinter Review
No space after the label. (7.50 KB, image/png)
2024-10-11 18:46 UTC, Esther Melander
Details
Bug 38055: Space between label and value for MARC field 530 (3.01 KB, patch)
2024-10-18 21:12 UTC, Eric Phetteplace
Details | Diff | Splinter Review
Bug 38055: Space between label and value for MARC field 530 (3.07 KB, patch)
2024-10-18 21:16 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38055: Space between label and value for MARC field 530 (3.13 KB, patch)
2024-10-25 15:01 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Phetteplace 2024-10-01 22:10:11 UTC Comment hidden (obsolete)
Comment 1 Eric Phetteplace 2024-10-01 22:18:16 UTC
Created attachment 172291 [details] [review]
Bug 38055: Space between label and value for MARC field 530
Comment 2 Esther Melander 2024-10-11 18:46:48 UTC
Created attachment 172701 [details]
No space after the label.

I tested this and there does not appear to be a space after the label. Result image attached.
Comment 3 Eric Phetteplace 2024-10-14 02:16:07 UTC
(In reply to Esther Melander from comment #2)
> Created attachment 172701 [details]
> No space after the label.
> 
> I tested this and there does not appear to be a space after the label.
> Result image attached.

Esther—did you restart Plack in between applying the patch and testing? That's `koha-plack --restart` (at least it is in a ktd shell). Sorry, that is my mistake, I should have it in the testing plan. If you did restart Plack, then I'll have to revisit this, since when I test locally I see the space.
Comment 4 Esther Melander 2024-10-15 18:43:19 UTC
Yes, I tested in a sandbox and restarted services, which restarted Plack. There is no space between the label and the text in the OPAC.
Comment 5 Eric Phetteplace 2024-10-18 21:12:49 UTC
Created attachment 172995 [details] [review]
Bug 38055: Space between label and value for MARC field 530

To test:

- Find a record with a 530 field or add a 530 to an existing record
- View record in OPAC — note no space between label and value
- Apply patch
- Restart Plack
- View record in OPAC — space is present
Comment 6 Eric Phetteplace 2024-10-18 21:16:36 UTC
(In reply to Esther Melander from comment #4)
> Yes, I tested in a sandbox and restarted services, which restarted Plack.
> There is no space between the label and the text in the OPAC.

Hi Esther, could you try again? I think perhaps my patch wasn't formatted correctly. I remade the patch with `git bz` and now when I test using the ByWater sandboxes I see a space after the colon.
Comment 7 Lucas Gass (lukeg) 2024-10-18 21:16:48 UTC
Created attachment 172996 [details] [review]
Bug 38055: Space between label and value for MARC field 530

To test:

- Find a record with a 530 field or add a 530 to an existing record
- View record in OPAC — note no space between label and value
- Apply patch
- Restart Plack
- View record in OPAC — space is present

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 8 Tomás Cohen Arazi (tcohen) 2024-10-25 15:01:10 UTC
Created attachment 173390 [details] [review]
Bug 38055: Space between label and value for MARC field 530

To test:

- Find a record with a 530 field or add a 530 to an existing record
- View record in OPAC — note no space between label and value
- Apply patch
- Restart Plack
- View record in OPAC — space is present

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 9 Katrin Fischer 2024-10-30 06:48:43 UTC
Pushed for 24.11!

Well done everyone, thank you!