The advanced editor apparently thought it could get away with using the class hidden from bootstrap.min.css to hide and show the checkmarks in the Settings menu next to framework names as you switch to a different framework. Boy did the Bootstrap5 upgrade show it that it was wrong, by just getting rid of bootstrap.min.css.
Created attachment 172293 [details] [review] Bug 38057: Fix checkmarks in Change framework menu in Advanced editor after Bootstrap5 update The advanced editor was using a class hidden from bootstrap.min.css to hide checkmarks in the part of the Settings menu that lets you change frameworks. Now that's gone, so it needs to have its own class. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - click the Settings menu 3. In Change framework, ... checkmarks, checkmarks everywhere, and they don't change when you choose a different one, so after the first change you can't even tell what's current 4. Apply patch, Shift+Reload the advanced editor page to bypass the cache 5. Click the Setting menu, see that only the current framework has a checkmark, change to a different one and reopen the Settings menu, see that the one you changed to now has the only checkmark Sponsored-by: Chetco Community Public Library
Created attachment 172296 [details] [review] Bug 38057: Fix checkmarks in Change framework menu in Advanced editor after Bootstrap5 update The advanced editor was using a class hidden from bootstrap.min.css to hide checkmarks in the part of the Settings menu that lets you change frameworks. Now that's gone, so it needs to have its own class. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - click the Settings menu 3. In Change framework, ... checkmarks, checkmarks everywhere, and they don't change when you choose a different one, so after the first change you can't even tell what's current 4. Apply patch, Shift+Reload the advanced editor page to bypass the cache 5. Click the Setting menu, see that only the current framework has a checkmark, change to a different one and reopen the Settings menu, see that the one you changed to now has the only checkmark Sponsored-by: Chetco Community Public Library Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Adding Owen here as this is bootstrap related and would be good to have his say here, I think.
Created attachment 172537 [details] [review] Bug 38057: Fix checkmarks in Change framework menu in Advanced editor after Bootstrap5 update The advanced editor was using a class hidden from bootstrap.min.css to hide checkmarks in the part of the Settings menu that lets you change frameworks. Now that's gone, so it needs to have its own class. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - click the Settings menu 3. In Change framework, ... checkmarks, checkmarks everywhere, and they don't change when you choose a different one, so after the first change you can't even tell what's current 4. Apply patch, Shift+Reload the advanced editor page to bypass the cache 5. Click the Setting menu, see that only the current framework has a checkmark, change to a different one and reopen the Settings menu, see that the one you changed to now has the only checkmark Sponsored-by: Chetco Community Public Library Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
The bug could also have been fixed by replacing the "hidden" class with the BS5 version, "invisible." But either way works!
I see an .invisible in the opac, but I don't see where it is in intranet-tmpl.
Ah, it magically appears (from outside the tree?) in staff-global.css.
(In reply to Phil Ringnalda from comment #7) > Ah, it magically appears (from outside the tree?) in staff-global.css. SCSS magic. Bootstrap is bundled into staff-global.css. https://getbootstrap.com/docs/5.3/utilities/visibility/
Created attachment 172664 [details] [review] Bug 38057: Fix checkmarks in Change framework menu in Advanced editor after Bootstrap5 update The advanced editor was using a class hidden from bootstrap.min.css to hide checkmarks in the part of the Settings menu that lets you change frameworks. Now that's gone, so it needs to have its own class. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - click the Settings menu 3. In Change framework, ... checkmarks, checkmarks everywhere, and they don't change when you choose a different one, so after the first change you can't even tell what's current 4. Apply patch, Shift+Reload the advanced editor page to bypass the cache 5. Click the Setting menu, see that only the current framework has a checkmark, change to a different one and reopen the Settings menu, see that the one you changed to now has the only checkmark Sponsored-by: Chetco Community Public Library Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed for 24.11! Well done everyone, thank you!
BS5 isn't going to 24.05, so this won't need to either.