Items with damaged status are shown on the OPAC results page as "Not available" even with AllowHoldsOnDamagedItems set to 'Allow', which is misleading for the users. 'other/Damaged' status should be assigned only if AllowHoldsOnDamagedItems is set to 'Don't allow'.
Created attachment 172426 [details] [review] Bug 38100: Items with damaged status are shown in OPAC results as "Not available" even with AllowHoldsOnDamagedItems Items with damaged status are shown on the OPAC results page as "Not available" even with AllowHoldsOnDamagedItems set to 'Allow', which is misleading for the users. 'other/Damaged' status should be assigned only if AllowHoldsOnDamagedItems is set to 'Don't allow'. Test plan: ========== 1. Check that AllowHoldsOnDamagedItems system preference is set to 'Allow'. 2. In librarian interface, change the damaged status of an item by setting it to 'Damaged'. 3. In OPAC, make a search for the record with this item attached. Use common words from title to get a list and not a single record. 4. Note that the item in question is labelled as 'Not available' (Damaged). 5. Apply the patch; restart_all. 6. Repeat p. 3. Note that the item is now labelled as 'available for loan'. 7. Set AllowHoldsOnDamagedItems system preference is set to 'Don't allow'. 8. Repeat p. 3. Note that the item is now labelled as 'Not available'.
Created attachment 172427 [details] [review] Bug 38100: Unit tests
Created attachment 172429 [details] [review] Bug 38100: Items with damaged status are shown in OPAC results as "Not available" even with AllowHoldsOnDamagedItems Items with damaged status are shown on the OPAC results page as "Not available" even with AllowHoldsOnDamagedItems set to 'Allow', which is misleading for the users. 'other/Damaged' status should be assigned only if AllowHoldsOnDamagedItems is set to 'Don't allow'. Test plan: ========== 1. Check that AllowHoldsOnDamagedItems system preference is set to 'Allow'. 2. In librarian interface, change the damaged status of an item by setting it to 'Damaged'. 3. In OPAC, make a search for the record with this item attached. Use common words from title to get a list and not a single record. 4. Note that the item in question is labelled as 'Not available' (Damaged). 5. Apply the patch; restart_all. 6. Repeat p. 3. Note that the item is now labelled as 'available for loan'. 7. Set AllowHoldsOnDamagedItems system preference is set to 'Don't allow'. 8. Repeat p. 3. Note that the item is now labelled as 'Not available'. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 172430 [details] [review] Bug 38100: Unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 174112 [details] [review] Bug 38100: Items with damaged status are shown in OPAC results as "Not available" even with AllowHoldsOnDamagedItems Items with damaged status are shown on the OPAC results page as "Not available" even with AllowHoldsOnDamagedItems set to 'Allow', which is misleading for the users. 'other/Damaged' status should be assigned only if AllowHoldsOnDamagedItems is set to 'Don't allow'. Test plan: ========== 1. Check that AllowHoldsOnDamagedItems system preference is set to 'Allow'. 2. In librarian interface, change the damaged status of an item by setting it to 'Damaged'. 3. In OPAC, make a search for the record with this item attached. Use common words from title to get a list and not a single record. 4. Note that the item in question is labelled as 'Not available' (Damaged). 5. Apply the patch; restart_all. 6. Repeat p. 3. Note that the item is now labelled as 'available for loan'. 7. Set AllowHoldsOnDamagedItems system preference is set to 'Don't allow'. 8. Repeat p. 3. Note that the item is now labelled as 'Not available'. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Created attachment 174113 [details] [review] Bug 38100: Unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Created attachment 174114 [details] [review] Bug 38100: (QA follow-up) Tidy changes in C4/XSLT.pm
I think if "Damaged" means available or not available is highly depending on the workflows of the library and how the status is used internally. But this makes it a bit more flexible, which is good.
Pushed for 24.11! Well done everyone, thank you!