Bug 38109 - Patron category types are not sorted when entering/editing patrons
Summary: Patron category types are not sorted when entering/editing patrons
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Pedro Amorim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-07 19:57 UTC by Nick Clemens (kidclamp)
Modified: 2024-11-18 22:56 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:

Attachments
Bug 38109: Sort patron category types before display (1.68 KB, patch)
2024-10-07 19:59 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 38109: Sort patron category types before display (1.73 KB, patch)
2024-10-07 21:06 UTC, Roman Dolny 		Details | Diff | Splinter Review
Bug 38109: Sort patron category types before display (1.79 KB, patch)
2024-10-08 08:31 UTC, Pedro Amorim 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2024-10-07 19:57:57 UTC 
To recreate:
1 - Patrons -> New patron -> {any category}
2 - Find the category dropdown
3 - Note the order of categories types
4 - Reload the page
5 - Note a new order
Comment 1 Nick Clemens (kidclamp) 2024-10-07 19:59:36 UTC 
Created attachment 172499 [details] [review]
Bug 38109: Sort patron category types before display

To test
1 - Patrons -> New patron -> {any category}
2 - Find the category dropdown
3 - Note the order of categories types
4 - Reload the page
5 - Note a new order
6 - Apply patch
7 - Refresh page, category types now ordered (by code)
8 - Refresh again, no change!
Comment 2 Roman Dolny 2024-10-07 21:06:55 UTC 
Created attachment 172500 [details] [review]
Bug 38109: Sort patron category types before display

To test
1 - Patrons -> New patron -> {any category}
2 - Find the category dropdown
3 - Note the order of categories types
4 - Reload the page
5 - Note a new order
6 - Apply patch
7 - Refresh page, category types now ordered (by code)
8 - Refresh again, no change!

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Pedro Amorim 2024-10-08 08:31:13 UTC 
Created attachment 172514 [details] [review]
Bug 38109: Sort patron category types before display

To test
1 - Patrons -> New patron -> {any category}
2 - Find the category dropdown
3 - Note the order of categories types
4 - Reload the page
5 - Note a new order
6 - Apply patch
7 - Refresh page, category types now ordered (by code)
8 - Refresh again, no change!

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 4 Katrin Fischer 2024-10-11 09:16:11 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass (lukeg) 2024-11-18 22:56:17 UTC 
Backported to 24.05.x for upcoming 24.05.06