38146 – Last seen date is missing the time in the item holdings table

Bug 38146 - Last seen date is missing the time in the item holdings table

Summary: Last seen date is missing the time in the item holdings table

Status:	Pushed to stable

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Staff interface (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low normal
Assignee:	Emily Lamancusa (emlam)
QA Contact:	Testopia

URL:
Keywords:	regression

Duplicates (1):	37688 (view as bug list)
Depends on:	33568
Blocks:
	Show dependency tree / graph

Reported:	2024-10-10 18:31 UTC by Emily Lamancusa (emlam)
Modified:	2024-11-19 15:47 UTC (History)
CC List:	4 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	24.11.00,24.05.06
Circulation function:

Attachments
Bug 38146: Display full datetime of datelastseen in item holdings (1.37 KB, patch) 2024-10-10 18:34 UTC, Emily Lamancusa (emlam)	Details \| Diff \| Splinter Review
Bug 38146: Display full datetime of datelastseen in item holdings (1.43 KB, patch) 2024-10-10 21:17 UTC, Phil Ringnalda	Details \| Diff \| Splinter Review
Bug 38146: Display full datetime of datelastseen in item holdings (1.50 KB, patch) 2024-10-15 13:39 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Emily Lamancusa (emlam) 2024-10-10 18:31:12 UTC

Comment 1 Emily Lamancusa (emlam) 2024-10-10 18:34:31 UTC

Created attachment 172667 [details] [review]
Bug 38146: Display full datetime of datelastseen in item holdings

To test:
1. Check in an item
2. Look at the item holdings table for the bib record that item is on
--> Note the date last seen column displays dates, but not the time
3. Apply patch and restart_all
4. Refresh the page
--> Date last seen column now shows the time you checked the item in

Comment 2 Phil Ringnalda 2024-10-10 21:17:22 UTC

Created attachment 172670 [details] [review]
Bug 38146: Display full datetime of datelastseen in item holdings

To test:
1. Check in an item
2. Look at the item holdings table for the bib record that item is on
--> Note the date last seen column displays dates, but not the time
3. Apply patch and restart_all
4. Refresh the page
--> Date last seen column now shows the time you checked the item in

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Comment 3 Jonathan Druart 2024-10-15 13:35:52 UTC

Are you sure it's a regression from bug 33568?

Comment 4 Jonathan Druart 2024-10-15 13:38:33 UTC

(In reply to Jonathan Druart from comment #3)
> Are you sure it's a regression from bug 33568?

Yes, looks like the code before was:
  <td class="datelastseen" data-order="[% item.datelastseen | html %]">[% item.datelastseen | $KohaDates with_hours => 1 %]</td>


Which then displayed: "05/07/2014 00:00" if the date has not been modified since we moved the datatype from date to datetime.

Comment 5 Jonathan Druart 2024-10-15 13:39:04 UTC

Created attachment 172776 [details] [review]
Bug 38146: Display full datetime of datelastseen in item holdings

To test:
1. Check in an item
2. Look at the item holdings table for the bib record that item is on
--> Note the date last seen column displays dates, but not the time
3. Apply patch and restart_all
4. Refresh the page
--> Date last seen column now shows the time you checked the item in

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 6 Jonathan Druart 2024-10-15 13:39:12 UTC

We may need to remove 00:00 but that's for another bug.

Comment 7 Katrin Fischer 2024-10-16 12:37:38 UTC

Pushed for 24.11!

Well done everyone, thank you!

Comment 8 Paul Derscheid 2024-10-28 14:20:03 UTC

*** Bug 37688 has been marked as a duplicate of this bug. ***

Comment 9 Lucas Gass (lukeg) 2024-11-19 15:47:43 UTC

Backported to 24.05.x for upcoming 24.05.06