Bug 38159 - Add count to Today's checkouts/Previous checkouts
Summary: Add count to Today's checkouts/Previous checkouts
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-11 19:59 UTC by Lucas Gass (lukeg)
Modified: 2025-04-09 20:50 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38159: Add count to todays/previous checkouts (1.98 KB, patch)
2024-10-11 20:02 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38159: Add count to todays/previous checkouts (2.29 KB, patch)
2025-04-02 09:57 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-10-11 19:59:16 UTC
In the issues table checkouts are separated by today's checkouts and previous checkouts.

Some libraris would find it handy if this included a count of the number of checks in each. 

ie: Today's checkouts (2)
Previous checkouts (1)
Comment 1 Lucas Gass (lukeg) 2024-10-11 20:02:57 UTC
Created attachment 172704 [details] [review]
Bug 38159: Add count to todays/previous checkouts

To test:
1. APPLY Patch
2. Make some checkouts.
3. Change some of the checkouts to have an older issuedate.
4. When you open the checkouts tables you should see something like Today's checkouts (2) and Previous checkouts (1).
Comment 2 Philip Orr 2025-04-01 11:36:55 UTC
Seems it needs a rebase, patch doesn't apply..

Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/js/checkouts.js
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/js/checkouts.js
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/checkouts.js
error: Failed to merge in the changes.
Patch failed at 0001 Bug 38159: Add count to todays/previous checkouts
Comment 3 Lucas Gass (lukeg) 2025-04-02 09:57:57 UTC
Created attachment 180282 [details] [review]
Bug 38159: Add count to todays/previous checkouts

To test:
1. APPLY Patch
2. Make some checkouts.
3. Change some of the checkouts to have an older issuedate.
4. When you open the checkouts tables you should see something like Today's checkouts (2) and Previous checkouts (1).
Comment 4 Philip Orr 2025-04-02 12:06:42 UTC
Thanks Lucas!
I tested and it works fine.
However - as soon as I click on one of the sorting headers in the issues table, the number in the parentheses disappears.
E.G. click on the "Title" column to sort by title -> Number disappears.
Comment 5 Andrew Auld 2025-04-03 12:59:00 UTC
I couldn't get this to work. The numbers don't appear for me.