Bug 38162 - Can't delete a stock rotation
Summary: Can't delete a stock rotation
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-12 14:00 UTC by Lucas Gass (lukeg)
Modified: 2024-11-18 23:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:

Attachments
Bug 38162: Pass the rota_id correctly when deleting (2.02 KB, patch)
2024-10-12 14:29 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 38162: Pass the rota_id correctly when deleting (2.07 KB, patch)
2024-10-15 13:33 UTC, ByWater Sandboxes 		Details | Diff | Splinter Review
Bug 38162: Pass the rota_id correctly when deleting (2.13 KB, patch)
2024-10-15 20:10 UTC, ByWater Sandboxes 		Details | Diff | Splinter Review
Bug 38162: Pass the rota_id correctly when deleting (2.20 KB, patch)
2024-10-15 20:39 UTC, Emily Lamancusa (emlam) 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-10-12 14:00:57 UTC 
To recreate:

1. Enable StockRotation 
2. Got to Cataloging -> Stock rotation 
3. Create a new Rota 
4. Try to delete it 
5. See the error "Can't call method "delete" on an undefined value at /kohadevbox/koha/tools/stockrotation.pl line 231"
Comment 1 Lucas Gass (lukeg) 2024-10-12 14:29:58 UTC 
Created attachment 172711 [details] [review]
Bug 38162: Pass the rota_id correctly when deleting

To test:

1. Enable StockRotation
2. Got to Cataloging -> Stock rotation
3. Create a new Rota
4. Try to delete it
5. See the error "Can't call method "delete" on an undefined value at /kohadevbox/koha/tools/stockrotation.pl line 231"
6. APPLY PATCH
7. Try again, the rota should be deleted properly.
Comment 2 ByWater Sandboxes 2024-10-15 13:33:58 UTC 
Created attachment 172775 [details] [review]
Bug 38162: Pass the rota_id correctly when deleting

To test:

1. Enable StockRotation
2. Got to Cataloging -> Stock rotation
3. Create a new Rota
4. Try to delete it
5. See the error "Can't call method "delete" on an undefined value at /kohadevbox/koha/tools/stockrotation.pl line 231"
6. APPLY PATCH
7. Try again, the rota should be deleted properly.

Signed-off-by: Laura ONeil <laura@bywatersolutions.com>
Comment 3 ByWater Sandboxes 2024-10-15 20:10:07 UTC 
Created attachment 172794 [details] [review]
Bug 38162: Pass the rota_id correctly when deleting

To test:

1. Enable StockRotation
2. Got to Cataloging -> Stock rotation
3. Create a new Rota
4. Try to delete it
5. See the error "Can't call method "delete" on an undefined value at /kohadevbox/koha/tools/stockrotation.pl line 231"
6. APPLY PATCH
7. Try again, the rota should be deleted properly.

Signed-off-by: Laura ONeil <laura@bywatersolutions.com>
Signed-off-by: Alyssa <alyssa.drake@bywatersolutions.com>
Comment 4 Emily Lamancusa (emlam) 2024-10-15 20:39:32 UTC 
Created attachment 172796 [details] [review]
Bug 38162: Pass the rota_id correctly when deleting

To test:

1. Enable StockRotation
2. Got to Cataloging -> Stock rotation
3. Create a new Rota
4. Try to delete it
5. See the error "Can't call method "delete" on an undefined value at /kohadevbox/koha/tools/stockrotation.pl line 231"
6. APPLY PATCH
7. Try again, the rota should be deleted properly.

Signed-off-by: Laura ONeil <laura@bywatersolutions.com>
Signed-off-by: Alyssa <alyssa.drake@bywatersolutions.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 5 Emily Lamancusa (emlam) 2024-10-15 20:40:47 UTC 
Thanks for catching that! Passing QA
Comment 6 Katrin Fischer 2024-10-16 12:37:41 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 Lucas Gass (lukeg) 2024-11-18 23:26:58 UTC 
Backported to 24.05.x for upcoming 24.05.06