Bug 38170 - xt/verify-yarnlock.t doesn't detect removal of packages
Summary: xt/verify-yarnlock.t doesn't detect removal of packages
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Chris Cormack
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-15 01:48 UTC by Victor Grousset/tuxayo
Modified: 2024-10-15 02:48 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Grousset/tuxayo 2024-10-15 01:48:49 UTC
Found while reviewing Bug 38164

Test plan (not dependent on Bug 38164 being merged or not)
1. From package.json, remove the 3 @fortawesome* packages
2. Run prove xt/verify-yarnlock.t
3. It works! :o


The test is working if I upgrade (edit package.json) webpack-cli from "^4.9.2" to "^5.1.4"

And it's working if I add in package.json this
"esperanto.js": "^1.1.0",
I just searched a package that has no dependency (maybe testing with random stuff is a bit dangerous ^^")

Are there other cases to handle?
Comment 1 Victor Grousset/tuxayo 2024-10-15 02:48:28 UTC
Maybe we are lucky and `yarn check` will handle this without us having to do anything on an up to date yarn.
That will depend on what happens with bug 36682 (upgrade yarn vs switch to pnpm)

If there is an equivalent concern with pnpm then hopefully there is something that can nicely replace `yarn check`.

At least we have the test cases here :)