Bug 38185 - DT - replace dom with layout
Summary: DT - replace dom with layout
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 36640
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-16 12:02 UTC by Jonathan Druart
Modified: 2025-07-31 15:05 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38185: wip (1.78 KB, patch)
2025-07-29 12:31 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38185: wip (1.85 KB, patch)
2025-07-29 12:34 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38185: Reintroduce .top.pager, .table_entries and .table_controls (2.62 KB, patch)
2025-07-29 13:35 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38185: Try to match current DataTable style using new layout option (7.63 KB, patch)
2025-07-30 13:18 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38185: Try to match current DataTable style using new layout option (7.65 KB, patch)
2025-07-30 16:28 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38185: Try to match current DataTable style using new layout option (7.62 KB, patch)
2025-07-31 14:07 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-10-16 12:02:17 UTC
https://datatables.net/upgrade/2#dom-property

"""
dom is still available in DataTables 2 (likely it will be dropped in v3 whenever that happens!), but the default CSS for DataTables has been updated for layout and does not include styling for dom. If you need to continue using dom, you will likely need to add some CSS to position the elements as you need. However, you are strongly encouraged to update to using layout.
"""
Comment 1 Jonathan Druart 2025-07-29 12:31:08 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2025-07-29 12:34:42 UTC
Created attachment 184797 [details] [review]
Bug 38185: wip
Comment 3 Jonathan Druart 2025-07-29 13:35:23 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2025-07-30 13:18:35 UTC Comment hidden (obsolete)
Comment 5 Owen Leonard 2025-07-30 16:28:15 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2025-07-31 09:56:01 UTC
(In reply to Owen Leonard from comment #5)
> Created attachment 184906 [details] [review] [review]
> Bug 38185: Try to match current DataTable style using new layout option

We lost the border at the bottom:
 .pager.bottom {
  border-bottom: 1px solid #BCBCBC;

And the First/Last buttons in the pagination.
Comment 7 Owen Leonard 2025-07-31 14:07:09 UTC
Created attachment 184928 [details] [review]
Bug 38185: Try to match current DataTable style using new layout option
Comment 8 Owen Leonard 2025-07-31 14:21:55 UTC
(In reply to Jonathan Druart from comment #6)

> And the First/Last buttons in the pagination.

Paging type is now obsolete and the responsive rules for the pagination links are supposed to replace those options. The actual behavior seems a little inconsistent.

https://datatables.net/reference/feature/paging.type
Comment 9 Owen Leonard 2025-07-31 15:05:15 UTC
> > And the First/Last buttons in the pagination.

Correction: This was indeed a mistake in the updated CSS. We have a custom rule that hides the first and last buttons when the screen width is below a certain value. The CSS for showing the buttons was lost.