Bug 38207 - Add vendor payment methods
Summary: Add vendor payment methods
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Matt Blenkinsop
QA Contact: Testopia
URL:
Keywords:
Depends on: 38010
Blocks: 23005
  Show dependency treegraph
 
Reported: 2024-10-18 14:31 UTC by Matt Blenkinsop
Modified: 2025-06-06 01:39 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement adds a 'Payment method" field to the ordering information section for a vendor. Options to use are added in the new VENDOR_PAYMENT_METHOD authorized values category.
Version(s) released in:
Circulation function:


Attachments
Bug 38207: Add a new payment_method column to aqbooksellers (4.31 KB, patch)
2024-12-04 10:13 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38207: DBIC file (1.01 KB, patch)
2024-12-04 10:13 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38207: Update UI to use new field (5.58 KB, patch)
2024-12-04 10:13 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38207: Update cypress tests (1.39 KB, patch)
2024-12-04 10:13 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38207: Add a new payment_method column to aqbooksellers (4.36 KB, patch)
2025-05-19 11:01 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38207: DBIC file (1021 bytes, patch)
2025-05-19 11:01 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38207: Update UI to use new field (5.83 KB, patch)
2025-05-19 11:01 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38207: Update cypress tests (1.37 KB, patch)
2025-05-19 11:01 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38207: Add a new payment_method column to aqbooksellers (4.40 KB, patch)
2025-06-06 01:23 UTC, David Nind
Details | Diff | Splinter Review
Bug 38207: DBIC file (1.04 KB, patch)
2025-06-06 01:23 UTC, David Nind
Details | Diff | Splinter Review
Bug 38207: Update UI to use new field (5.87 KB, patch)
2025-06-06 01:23 UTC, David Nind
Details | Diff | Splinter Review
Bug 38207: Update cypress tests (1.42 KB, patch)
2025-06-06 01:23 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2024-10-18 14:31:24 UTC
It would be useful to identify the payment methods for a vendor, ideally as authorised values
Comment 1 Matt Blenkinsop 2024-12-04 10:13:15 UTC
Created attachment 175140 [details] [review]
Bug 38207: Add a new payment_method column to aqbooksellers

(cherry picked from commit 881f96172a8c1b35d3e74f7f0f6aa44629578021)
Comment 2 Matt Blenkinsop 2024-12-04 10:13:17 UTC
Created attachment 175141 [details] [review]
Bug 38207: DBIC file
Comment 3 Matt Blenkinsop 2024-12-04 10:13:20 UTC
Created attachment 175142 [details] [review]
Bug 38207: Update UI to use new field
Comment 4 Matt Blenkinsop 2024-12-04 10:13:22 UTC
Created attachment 175143 [details] [review]
Bug 38207: Update cypress tests

(cherry picked from commit 61bcde708a970d1bca07e4a803ae5dfe78c16c89)
Comment 5 Emmanuel Bétemps 2025-01-13 13:53:30 UTC
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 38010: Delete old code
Comment 6 Matt Blenkinsop 2025-05-19 11:01:02 UTC
Created attachment 182584 [details] [review]
Bug 38207: Add a new payment_method column to aqbooksellers

(cherry picked from commit 881f96172a8c1b35d3e74f7f0f6aa44629578021)
Comment 7 Matt Blenkinsop 2025-05-19 11:01:04 UTC
Created attachment 182585 [details] [review]
Bug 38207: DBIC file
Comment 8 Matt Blenkinsop 2025-05-19 11:01:07 UTC
Created attachment 182586 [details] [review]
Bug 38207: Update UI to use new field
Comment 9 Matt Blenkinsop 2025-05-19 11:01:09 UTC
Created attachment 182587 [details] [review]
Bug 38207: Update cypress tests

(cherry picked from commit 61bcde708a970d1bca07e4a803ae5dfe78c16c89)
Comment 10 David Nind 2025-06-06 01:23:07 UTC
Created attachment 183017 [details] [review]
Bug 38207: Add a new payment_method column to aqbooksellers

(cherry picked from commit 881f96172a8c1b35d3e74f7f0f6aa44629578021)
Signed-off-by: David Nind <david@davidnind.com>
Comment 11 David Nind 2025-06-06 01:23:10 UTC
Created attachment 183018 [details] [review]
Bug 38207: DBIC file

Signed-off-by: David Nind <david@davidnind.com>
Comment 12 David Nind 2025-06-06 01:23:13 UTC
Created attachment 183019 [details] [review]
Bug 38207: Update UI to use new field

Signed-off-by: David Nind <david@davidnind.com>
Comment 13 David Nind 2025-06-06 01:23:16 UTC
Created attachment 183020 [details] [review]
Bug 38207: Update cypress tests

(cherry picked from commit 61bcde708a970d1bca07e4a803ae5dfe78c16c89)
Signed-off-by: David Nind <david@davidnind.com>
Comment 14 David Nind 2025-06-06 01:39:07 UTC
I have one suggestion - add a description to the new VENDOR_PAYMENT_METHOD authorized value category: "Values for the 'payment method' field in the acquisitions module."

Testing notes (using KTD):
1. Apply the patch
2. Update the database: updatedatabase
3. Rebuild the schema: dbic
4. Rebuild the Vue application: yarn build
5. Restart everything: restart_all
6. Clear your browser cache.
7. Note that there is a new authorized value category VENDOR_PAYMENT_METHOD: Koha administration > Basic categories > Authorized values > VENDOR_PAYMENT_METHOD
8. Note that on the ordering information section for a vendor's information page (or add a new vendor), there is a new 'Payment method' field: Acquisitions > Search vendors > [select a vendor] > Ordering information
9. Add a payment type to an existing vendor, or add a new vendor: Acquisitions > Search vendors > [select a vendor - My Vendor] > Edit vendor
10. Run the tests - these should pass: yarn cypress run --spec t/cypress/integration/Acquisitions/Vendors_spec.ts