It would be useful to identify the payment methods for a vendor, ideally as authorised values
Created attachment 175140 [details] [review] Bug 38207: Add a new payment_method column to aqbooksellers (cherry picked from commit 881f96172a8c1b35d3e74f7f0f6aa44629578021)
Created attachment 175141 [details] [review] Bug 38207: DBIC file
Created attachment 175142 [details] [review] Bug 38207: Update UI to use new field
Created attachment 175143 [details] [review] Bug 38207: Update cypress tests (cherry picked from commit 61bcde708a970d1bca07e4a803ae5dfe78c16c89)
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt). error: could not build fake ancestor Patch failed at 0001 Bug 38010: Delete old code
Created attachment 182584 [details] [review] Bug 38207: Add a new payment_method column to aqbooksellers (cherry picked from commit 881f96172a8c1b35d3e74f7f0f6aa44629578021)
Created attachment 182585 [details] [review] Bug 38207: DBIC file
Created attachment 182586 [details] [review] Bug 38207: Update UI to use new field
Created attachment 182587 [details] [review] Bug 38207: Update cypress tests (cherry picked from commit 61bcde708a970d1bca07e4a803ae5dfe78c16c89)
Created attachment 183017 [details] [review] Bug 38207: Add a new payment_method column to aqbooksellers (cherry picked from commit 881f96172a8c1b35d3e74f7f0f6aa44629578021) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 183018 [details] [review] Bug 38207: DBIC file Signed-off-by: David Nind <david@davidnind.com>
Created attachment 183019 [details] [review] Bug 38207: Update UI to use new field Signed-off-by: David Nind <david@davidnind.com>
Created attachment 183020 [details] [review] Bug 38207: Update cypress tests (cherry picked from commit 61bcde708a970d1bca07e4a803ae5dfe78c16c89) Signed-off-by: David Nind <david@davidnind.com>
I have one suggestion - add a description to the new VENDOR_PAYMENT_METHOD authorized value category: "Values for the 'payment method' field in the acquisitions module." Testing notes (using KTD): 1. Apply the patch 2. Update the database: updatedatabase 3. Rebuild the schema: dbic 4. Rebuild the Vue application: yarn build 5. Restart everything: restart_all 6. Clear your browser cache. 7. Note that there is a new authorized value category VENDOR_PAYMENT_METHOD: Koha administration > Basic categories > Authorized values > VENDOR_PAYMENT_METHOD 8. Note that on the ordering information section for a vendor's information page (or add a new vendor), there is a new 'Payment method' field: Acquisitions > Search vendors > [select a vendor] > Ordering information 9. Add a payment type to an existing vendor, or add a new vendor: Acquisitions > Search vendors > [select a vendor - My Vendor] > Edit vendor 10. Run the tests - these should pass: yarn cypress run --spec t/cypress/integration/Acquisitions/Vendors_spec.ts
Created attachment 188405 [details] [review] Bug 38207: Add a new payment_method column to aqbooksellers (cherry picked from commit 881f96172a8c1b35d3e74f7f0f6aa44629578021) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 188406 [details] [review] Bug 38207: DBIC file Signed-off-by: David Nind <david@davidnind.com>
Created attachment 188407 [details] [review] Bug 38207: Update UI to use new field Signed-off-by: David Nind <david@davidnind.com>
Created attachment 188408 [details] [review] Bug 38207: Update cypress tests (cherry picked from commit 61bcde708a970d1bca07e4a803ae5dfe78c16c89) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 190793 [details] [review] Bug 38207: Add a new payment_method column to aqbooksellers (cherry picked from commit 881f96172a8c1b35d3e74f7f0f6aa44629578021) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 190794 [details] [review] Bug 38207: DBIC file Signed-off-by: David Nind <david@davidnind.com>
Created attachment 190795 [details] [review] Bug 38207: Update UI to use new field Signed-off-by: David Nind <david@davidnind.com>
Created attachment 190796 [details] [review] Bug 38207: Update cypress tests (cherry picked from commit 61bcde708a970d1bca07e4a803ae5dfe78c16c89) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 190797 [details] [review] Bug 38207: Add exec flag to atomicupdate
Nice work everyone! Pushed to main for 26.05
This caused some Cypress failures: Cannot read properties of undefined (reading 'authorised_values') Because there are no AV for VENDOR_PAYMENT_METHOD First question is: is it expect to have the 2 Card and BACS created only for upgraded installs? Then I think we should fix koha-tmpl/intranet-tmpl/prog/js/vue/composables/authorisedValues.js to fix this situation, but it should be a separate bug I'd say.
Actually it's because the *category* is missing for new installation.
Created attachment 192012 [details] [review] Bug 38207: Add VENDOR_PAYMENT_METHOD for new installs Patch from commit c329d45
follow-up pushed to main