Bug 38221 - Add Bootstrap styling to pagination in authority plugin search results
Summary: Add Bootstrap styling to pagination in authority plugin search results
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 38227
  Show dependency tree / graph
 
Reported: 2024-10-22 10:46 UTC by Owen Leonard
Modified: 2025-01-10 01:53 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement updates the style of the pagination links in the cataloging authority search popup (for example, 100$a). The style is now consistent with other pages (such as catalog search results), instead of plain links for result page numbers and angle brackets for next, last, first, and previous page links.
Version(s) released in:
25.05.00
Circulation function:

Attachments
Bug 38221: Add Bootstrap styling to pagination in authority plugin search results (9.45 KB, patch)
2024-10-22 12:07 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 38221: Add Bootstrap styling to pagination in authority plugin search results (9.50 KB, patch)
2024-10-22 20:25 UTC, Phil Ringnalda 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-10-22 10:46:15 UTC 
When using the authority plugin in basic MARC cataloging, the authority search results in the popup window have unstyled links for pagination. We can add Bootstrap styling to these links to make them more visible and more consistent with other pages.
Comment 1 Owen Leonard 2024-10-22 12:07:17 UTC 
Created attachment 173131 [details] [review]
Bug 38221: Add Bootstrap styling to pagination in authority plugin search results

This patch updates the markup of pagination links in the authority
search popup so that they have Bootstrap styling consistent with other
pages (e.g. catalog search results).

The pagination markup has also been moved to a BLOCK so that it can be
reused instead of duplicated on the page.

To test, apply the patch and go to Cataloging -> New record (using the
basic MARC editor).

- Switch to tab 1 and click the tag editor link next to tag 100 subfield
  a.
- Perform a search in the popup window which will return multiple pages
  of results (an empty search will work with default testing data).
- Confirm that the pagination links are styled like catalog search
  results.
- Confirm that the search links work correctly and that the correct
  number is highlighted as you page through results.

Sponsored-by: Athens County Public Libraries
Comment 2 Phil Ringnalda 2024-10-22 20:25:39 UTC 
Created attachment 173186 [details] [review]
Bug 38221: Add Bootstrap styling to pagination in authority plugin search results

This patch updates the markup of pagination links in the authority
search popup so that they have Bootstrap styling consistent with other
pages (e.g. catalog search results).

The pagination markup has also been moved to a BLOCK so that it can be
reused instead of duplicated on the page.

To test, apply the patch and go to Cataloging -> New record (using the
basic MARC editor).

- Switch to tab 1 and click the tag editor link next to tag 100 subfield
  a.
- Perform a search in the popup window which will return multiple pages
  of results (an empty search will work with default testing data).
- Confirm that the pagination links are styled like catalog search
  results.
- Confirm that the search links work correctly and that the correct
  number is highlighted as you page through results.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Phil Ringnalda 2024-10-22 20:26:40 UTC 
Testing notes: also tested in the advanced editor, and in the 500s in the authority editor, since we've been burned before by the way the same script does all three.
Comment 4 Katrin Fischer 2024-12-27 16:21:36 UTC 
(In reply to Phil Ringnalda from comment #3)
> Testing notes: also tested in the advanced editor, and in the 500s in the
> authority editor, since we've been burned before by the way the same script
> does all three.

Thanks, Phil!

QA by RM.
Comment 5 Katrin Fischer 2024-12-27 16:36:26 UTC 
Pushed for 25.05!

Well done everyone, thank you!