Bug 38231 - Adjust CSS for search result controls in the OPAC
Summary: Adjust CSS for search result controls in the OPAC
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-22 17:30 UTC by Owen Leonard
Modified: 2024-12-05 19:18 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:


Attachments
Screenshot showing alignment problems (205.60 KB, image/png)
2024-10-22 17:30 UTC, Owen Leonard
Details
Screenshot showing CSS adjustments (204.68 KB, image/png)
2024-10-22 17:30 UTC, Owen Leonard
Details
Bug 38231: Adjust CSS for search result controls in the OPAC (8.99 KB, patch)
2024-10-22 17:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38231: Adjust CSS for search result controls in the OPAC (9.04 KB, patch)
2024-10-25 15:42 UTC, Yanjun Li
Details | Diff | Splinter Review
Bug 38231: Adjust CSS for search result controls in the OPAC (9.11 KB, patch)
2024-10-28 15:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-10-22 17:30:06 UTC
Created attachment 173179 [details]
Screenshot showing alignment problems

In the "mobile" view of OPAC search results, the controls for each result like "place hold," "add to cart," etc. are out of alignment.
Comment 1 Owen Leonard 2024-10-22 17:30:34 UTC
Created attachment 173180 [details]
Screenshot showing CSS adjustments
Comment 2 Owen Leonard 2024-10-22 17:43:55 UTC
Created attachment 173181 [details] [review]
Bug 38231: Adjust CSS for search result controls in the OPAC

This patch makes some markup and CSS changes to the OPAC so that
controls are aligned correctly in the "mobile" view's catalog search
results. The patch also removes the border from the controls... I think
the borders looks out of place.

To test apply the patch and rebuild the OPAC CSS.

- Perform a catalog search.
- Check the styling of the controls shown for each search result, e.g.
  Place hold, Add tg, Save to lists, etc.
  - Make sure the controls work well when the browser window is various
    widths, from ~600px and up.

Sponsored-by: Athens County Public Libraries
Comment 3 Yanjun Li 2024-10-25 15:42:54 UTC
Created attachment 173396 [details] [review]
Bug 38231: Adjust CSS for search result controls in the OPAC

This patch makes some markup and CSS changes to the OPAC so that
controls are aligned correctly in the "mobile" view's catalog search
results. The patch also removes the border from the controls... I think
the borders looks out of place.

To test apply the patch and rebuild the OPAC CSS.

- Perform a catalog search.
- Check the styling of the controls shown for each search result, e.g.
  Place hold, Add tg, Save to lists, etc.
  - Make sure the controls work well when the browser window is various
    widths, from ~600px and up.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Yanjun Li <yanjun.li@bywatersolutions.com>
Comment 4 Martin Renvoize (ashimema) 2024-10-28 15:40:33 UTC
Created attachment 173566 [details] [review]
Bug 38231: Adjust CSS for search result controls in the OPAC

This patch makes some markup and CSS changes to the OPAC so that
controls are aligned correctly in the "mobile" view's catalog search
results. The patch also removes the border from the controls... I think
the borders looks out of place.

To test apply the patch and rebuild the OPAC CSS.

- Perform a catalog search.
- Check the styling of the controls shown for each search result, e.g.
  Place hold, Add tg, Save to lists, etc.
  - Make sure the controls work well when the browser window is various
    widths, from ~600px and up.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Yanjun Li <yanjun.li@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-10-29 15:18:14 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-12-05 19:16:37 UTC
Backported to 24.05.x for upcoming 24.05.06