Created attachment 173211 [details] [review] Bug 38237: Add logging to erm_run_harvester cronjob This patch simply adds logging to the cronjob To test: 1 - Enable CronjobLog http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=CronjobLog 2 - Enable ERMModule http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ERMModule 3 - Home -> E-resource Management -> Data providers -> New data provider Fill from registry or create your own, but change the URL and put in any required numbers We don't need a real test, just to run the ob 4 - perl misc/cronjobs/erm_run_harvester.pl --begin-date 2024-01-01 --dry-run --debug 5 - View the logs, no log of the script 6 - Apply patches 7 - Run the job again 8 - Check logs 9 - Success!
Created attachment 173212 [details] [review] Bug 38237: Add POD This patch adds POD to the script and rpelaces the custom help script with pod2usage TO test: perl misc/cronjobs/erm_run_harvester.pl Confirm you get helpful usage data
Created attachment 173219 [details] [review] Bug 38237: Add logging to erm_run_harvester cronjob This patch simply adds logging to the cronjob To test: 1 - Enable CronjobLog http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=CronjobLog 2 - Enable ERMModule http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ERMModule 3 - Home -> E-resource Management -> Data providers -> New data provider Fill from registry or create your own, but change the URL and put in any required numbers We don't need a real test, just to run the ob 4 - perl misc/cronjobs/erm_run_harvester.pl --begin-date 2024-01-01 --dry-run --debug 5 - View the logs, no log of the script 6 - Apply patches 7 - Run the job again 8 - Check logs 9 - Success! Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 173220 [details] [review] Bug 38237: Add POD This patch adds POD to the script and rpelaces the custom help script with pod2usage TO test: perl misc/cronjobs/erm_run_harvester.pl Confirm you get helpful usage data Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Skipping QA here. Happy to have it put back to SO if Katrin decides to do so!
Love to see the improved documentation!
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11
Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason.