Bug 38239 - Incorrect number of items to pull in holds to pull report with partially filled holds
Summary: Incorrect number of items to pull in holds to pull report with partially fill...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Janusz Kaczmarek
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-23 13:24 UTC by Janusz Kaczmarek
Modified: 2024-11-19 15:36 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38239: Incorrect number of items to pull (in Holds to pull) with partially filled holds (1.81 KB, patch)
2024-10-23 13:41 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 38239: Incorrect number of items to pull (in Holds to pull) with partially filled holds (1.86 KB, patch)
2024-10-23 15:17 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 38239: Incorrect number of items to pull (in Holds to pull) with partially filled holds (1.95 KB, patch)
2024-11-15 07:31 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2024-10-23 13:24:36 UTC
With a over-sufficient number of items, when more than one patron has placed hold, and the holds have been partially filled (checked-in = waiting for pick up), the number of items to pull in the Holds to pull table shows the total number of holds, including those waiting.  This erroneously suggests to the librarian to pull an excessive number of items from the shelves.
Comment 1 Janusz Kaczmarek 2024-10-23 13:41:19 UTC
Created attachment 173218 [details] [review]
Bug 38239: Incorrect number of items to pull (in Holds to pull) with partially filled holds

With a over-sufficient number of items, when more than one patron has
placed hold, and the holds have been partially filled (checked-in =
waiting for pick up), the number of items to pull in the Holds
to pull table shows the total number of holds, including those waiting.
This erroneously suggests to the librarian to pull an excessive number
of items from the shelves.

Test plan:
==========

1. For a bibliographic record with more than two items (in ktd, e.g.
   "Lanark a life in four books"), place hold for two patrons.
2. On the Holds to pull page control that there are two items to pull.
3. As a librarian from the library of one of the patrons, Check-in one
   item.
4. Note that in Holds to pull table you still see two items to pull,
   which is misleading.
5. Apply the patch; restart_all.
6. Now you should see only one item to be pulled.

Sponsored-by: Ignatianum University in Cracow
Comment 2 Roman Dolny 2024-10-23 15:17:38 UTC
Created attachment 173226 [details] [review]
Bug 38239: Incorrect number of items to pull (in Holds to pull) with partially filled holds

With a over-sufficient number of items, when more than one patron has
placed hold, and the holds have been partially filled (checked-in =
waiting for pick up), the number of items to pull in the Holds
to pull table shows the total number of holds, including those waiting.
This erroneously suggests to the librarian to pull an excessive number
of items from the shelves.

Test plan:
==========

1. For a bibliographic record with more than two items (in ktd, e.g.
   "Lanark a life in four books"), place hold for two patrons.
2. On the Holds to pull page control that there are two items to pull.
3. As a librarian from the library of one of the patrons, Check-in one
   item.
4. Note that in Holds to pull table you still see two items to pull,
   which is misleading.
5. Apply the patch; restart_all.
6. Now you should see only one item to be pulled.

Sponsored-by: Ignatianum University in Cracow
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Marcel de Rooy 2024-11-15 07:31:54 UTC
Created attachment 174540 [details] [review]
Bug 38239: Incorrect number of items to pull (in Holds to pull) with partially filled holds

With a over-sufficient number of items, when more than one patron has
placed hold, and the holds have been partially filled (checked-in =
waiting for pick up), the number of items to pull in the Holds
to pull table shows the total number of holds, including those waiting.
This erroneously suggests to the librarian to pull an excessive number
of items from the shelves.

Test plan:
==========

1. For a bibliographic record with more than two items (in ktd, e.g.
   "Lanark a life in four books"), place hold for two patrons.
2. On the Holds to pull page control that there are two items to pull.
3. As a librarian from the library of one of the patrons, Check-in one
   item.
4. Note that in Holds to pull table you still see two items to pull,
   which is misleading.
5. Apply the patch; restart_all.
6. Now you should see only one item to be pulled.

Sponsored-by: Ignatianum University in Cracow
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-11-19 15:36:43 UTC
Pushed for 24.11!

Well done everyone, thank you!