Bib records created through the EDI process don't always include the 008 field which can cause breakages when connected to discovery systems that require it. We need to set a default field on those records as it is a mandatory MARC field
Created attachment 173347 [details] [review] Bug 38271: Handle missing 008 fields in EDI This patch adds handling to create a default 008 field on MARC records that are missing one when created through EDI. Test plan: 1) prove t/db_dependent/Koha/EDI.t
Created attachment 173357 [details] [review] Bug 38271: Handle missing 008 fields in EDI This patch adds handling to create a default 008 field on MARC records that are missing one when created through EDI. Test plan: 1) prove t/db_dependent/Koha/EDI.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 173358 [details] [review] Bug 38271: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Upgrading Kyle's SO to a QA.. I'm happy with the code and there's very very few of us our here who understand EDI well enough to QA.
Created attachment 173442 [details] [review] Bug 38271: (QA follow-up) Fix testcritic testcritic was failing due to a 'return undef' so this commit amends that Test plan: 1) prove t/00-testcritic.t
Created attachment 173490 [details] [review] Bug 38271: (QA follow-up) Fix testcritic testcritic was failing due to a 'return undef' so this commit amends that Test plan: 1) prove t/00-testcritic.t
Happy to see unit tests!
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11
Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason.