Bug 38274 - Typo in Arabic language description
Summary: Typo in Arabic language description
Status: Pushed to oldoldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Fridolin Somers
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-25 14:23 UTC by Fridolin Somers
Modified: 2024-12-13 15:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the language description for Arabic (displayed in OPAC and the staff interface advanced search) - from "Arabic (لعربية)" to "Arabic (العربية)".
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:


Attachments
Bug 38274: Fix typo in arabic language description (2.33 KB, patch)
2024-10-25 14:37 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 38274: Fix typo in arabic language description (2.37 KB, patch)
2024-10-25 18:48 UTC, David Nind
Details | Diff | Splinter Review
Bug 38274: Fix typo in arabic language description (2.44 KB, patch)
2024-10-28 10:11 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2024-10-25 14:23:34 UTC
In installer/data/mysql/mandatory/subtag_registry.sql we see :

INSERT INTO language_descriptions(subtag, type, lang, description)
VALUES ( 'Arab','script', 'Arab', 'العربية');

And
INSERT INTO language_descriptions(subtag, type, lang, description)
VALUES ( 'ar', 'language', 'ar', 'لعربية');

This second part is missing a character.

Wee see this was correct before Bug 12250 :
العربية
Comment 1 Fridolin Somers 2024-10-25 14:37:52 UTC
Created attachment 173372 [details] [review]
Bug 38274: Fix typo in arabic language description

In installer/data/mysql/mandatory/subtag_registry.sql we see a missing
char in arabic language description.

Wee see this was correct before Bug 12250 :
العربية

Test plan :
1) Install a fresh Koha with this patch
2) Look in database :
   SELECT * FROM language_descriptions WHERE subtag='ar' AND type='language' AND lang='ar'
=> Check description is correct
3) On a old existing Koha
4) Install patch and run update database
=> Look in database and check description is correct
Comment 2 David Nind 2024-10-25 18:48:35 UTC
Created attachment 173409 [details] [review]
Bug 38274: Fix typo in arabic language description

In installer/data/mysql/mandatory/subtag_registry.sql we see a missing
char in arabic language description.

Wee see this was correct before Bug 12250 :
العربية

Test plan :
1) Install a fresh Koha with this patch
2) Look in database :
   SELECT * FROM language_descriptions WHERE subtag='ar' AND type='language' AND lang='ar'
=> Check description is correct
3) On a old existing Koha
4) Install patch and run update database
=> Look in database and check description is correct

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2024-10-28 10:11:59 UTC
Created attachment 173487 [details] [review]
Bug 38274: Fix typo in arabic language description

In installer/data/mysql/mandatory/subtag_registry.sql we see a missing
char in arabic language description.

Wee see this was correct before Bug 12250 :
&#1575;&#1604;&#1593;&#1585;&#1576;&#1610;&#1577;

Test plan :
1) Install a fresh Koha with this patch
2) Look in database :
   SELECT * FROM language_descriptions WHERE subtag='ar' AND type='language' AND lang='ar'
=> Check description is correct
3) On a old existing Koha
4) Install patch and run update database
=> Look in database and check description is correct

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Katrin Fischer 2024-10-28 18:28:16 UTC
Please don't leave out the say_success line in the database updates. 
Fixed on push.
Comment 5 Katrin Fischer 2024-10-29 07:54:49 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-11-04 16:13:18 UTC
(In reply to Katrin Fischer from comment #4)
> Please don't leave out the say_success line in the database updates. 
> Fixed on push.

Oh sorry I'm not yet accustomed to it since I a lot on 23.11 :D
Comment 7 Lucas Gass (lukeg) 2024-11-22 21:36:26 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 8 Fridolin Somers 2024-12-13 15:33:06 UTC
Pushed to 23.11.x for 23.11.11