Bug 38288 - Provide openURL backwards compatibility with FreeForm
Summary: Provide openURL backwards compatibility with FreeForm
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Pedro Amorim
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 35570
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-29 14:36 UTC by Pedro Amorim
Modified: 2024-10-31 10:33 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38288: Fallback to Standard if FreeForm (1.15 KB, patch)
2024-10-29 14:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38288: Fallback to Standard if FreeForm (1.20 KB, patch)
2024-10-29 21:29 UTC, David Nind
Details | Diff | Splinter Review
Bug 38288: Fallback to Standard if FreeForm (1.26 KB, patch)
2024-10-31 07:24 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-10-29 14:36:50 UTC

    
Comment 1 Pedro Amorim 2024-10-29 14:38:52 UTC
Created attachment 173658 [details] [review]
Bug 38288: Fallback to Standard if FreeForm

A regular openURL works fine:
http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?backend=Standard&title=Koha%20is%20cool&method=create&genre=article&openurl=1

Problem is existing third-party systems may be linking to Koha using FreeForm, not Standard

Test plan:
1) Access the OPAC URL from above.
2) Notice it works.
3) Replace the word 'Standard' with 'FreeForm'. It no longer works.
4) Apply patch. Repeat.
Comment 2 David Nind 2024-10-29 21:29:13 UTC
Created attachment 173691 [details] [review]
Bug 38288: Fallback to Standard if FreeForm

A regular openURL works fine:
http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?backend=Standard&title=Koha%20is%20cool&method=create&genre=article&openurl=1

Problem is existing third-party systems may be linking to Koha using FreeForm, not Standard

Test plan:
1) Access the OPAC URL from above.
2) Notice it works.
3) Replace the word 'Standard' with 'FreeForm'. It no longer works.
4) Apply patch. Repeat.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-10-29 21:30:03 UTC
Testing notes (using KTD):

1. Apply bug 35570
2. Update the database: updatedatabase
3. Restart everything: restart_all
4. Enable the ILL module: ILLModule
5. Follow the test plan
6. When applying 38288, say 'n' to applying dependent patches
Comment 4 Martin Renvoize (ashimema) 2024-10-31 07:24:07 UTC
Created attachment 173751 [details] [review]
Bug 38288: Fallback to Standard if FreeForm

A regular openURL works fine:
http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?backend=Standard&title=Koha%20is%20cool&method=create&genre=article&openurl=1

Problem is existing third-party systems may be linking to Koha using FreeForm, not Standard

Test plan:
1) Access the OPAC URL from above.
2) Notice it works.
3) Replace the word 'Standard' with 'FreeForm'. It no longer works.
4) Apply patch. Repeat.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2024-10-31 07:24:27 UTC
Simple follow-up for bug 35570.  All working, Passing QA
Comment 6 Katrin Fischer 2024-10-31 10:33:45 UTC
Pushed for 24.11!

Well done everyone, thank you!