I just noticed in ktd that trying to add Specific OPAC JS or Specific OPAC CSS won't work and causes a Javascript error to appear in the console
Created attachment 173697 [details] [review] Bug 38293: Fix setting branch-level JS and CSS Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/admin/branches.pl? op=add_form&branchcode=CPL 3. Scroll to bottom of the page and click "Edit" then "Collapse" next to Specific OPAC JS and Specific OPAC CSS
Created attachment 173698 [details] [review] Bug 38293: (alternate) Fix setting branch-level JS and CSS Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/admin/branches.pl? op=add_form&branchcode=CPL 3. Scroll to bottom of the page and click "Edit" then "Collapse" next to Specific OPAC JS and Specific OPAC CSS
I've got 2 possible fixes here, and copying in Owen as I'm not 100% sure what the right one is. I think the right one is probably the "alternate", or maybe a variation on the alternate. Basically, I don't think Bootstrap is involved with these textareas, so I think it was probably just updated by accident. But maybe we should change the attribute from "target" to something else, so it doesn't get confused with a Bootstrap control.
Created attachment 173707 [details] [review] Bug 38293: (alternate) Fix setting branch-level JS and CSS Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 3. Scroll to bottom of the page and click "Edit" then "Collapse" next to Specific OPAC JS and Specific OPAC CSS Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to David Cook from comment #3) > Basically, I don't think Bootstrap is involved with these textareas, so I > think it was probably just updated by accident. This is correct. Thanks for finding it!
Created attachment 173726 [details] [review] Bug 38293: (alternate) Fix setting branch-level JS and CSS Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 3. Scroll to bottom of the page and click "Edit" then "Collapse" next to Specific OPAC JS and Specific OPAC CSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 173737 [details] [review] Bug 38293: (alternate) Fix setting branch-level JS and CSS Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 3. Scroll to bottom of the page and click "Edit" then "Collapse" next to Specific OPAC JS and Specific OPAC CSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Pushed for 24.11! Well done everyone, thank you!